Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iidm-api and iidm-converter-api modules merging #683

Closed
geofjamg opened this issue Mar 12, 2019 · 1 comment
Closed

iidm-api and iidm-converter-api modules merging #683

geofjamg opened this issue Mar 12, 2019 · 1 comment

Comments

@geofjamg
Copy link
Member

  • Do you want to request a feature or report a bug?
    A feature.

  • What is the current behavior?
    We have 2 differents Maven modules for IIDM API and IIDM converter API. The first one is responsible for network model API and second one for network import/export plugin API.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
    N/A

  • What is the expected behavior?
    N/A

  • What is the motivation / use case for changing the behavior?
    2 motivations:

    • simplification: iidm-converter-api is never add as a dependency on its own and it is indissociable to iidm-api. It would be simplier for users to only have to include iidm-api.
    • my main motivation is to be able to write this which is a more Java idiomatic design and more natural for developpers:
Network n = Network.load("/tmp/n.zip");

instead of

Network n = Importers.load("/tmp/n.zip");
  • Please tell us about your environment:

    • PowSyBl Version: 2.4.0-SNAPSHOT
    • OS Version: Linux
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
    N/A

@annetill
Copy link
Member

Solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants