Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change packaging for converters #717

Closed
wants to merge 9 commits into from

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 26, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
This PR fixes #683 .

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a change of packaging for converters in order to homogenize the packages' names and simplify the framework.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. The new module names and packages are the following:
cgmes-converter
Package: com.powsybl.cgmes.converter
Module: com.powsybl.cgmes.converter

iidm-converter-api [DELETED (moved in iidm-api)]

iidm-api
Package: com.powsybl.iidm.api
Module: com.powsybl.iidm.api

iidm-xml-converter
Package: com.powsybl.iidm.xml
Module: com.powsybl.iidm.xml.converter

ampl-converter -> iidm-dsv-converter
Package: com.powsybl.iidm.dsv
Module: com.powsybl.iidm.dsv.converter

ucte-model
Package: com.powsybl.ucte.model
Module: com.powsybl.ucte.model

ucte-converter
Package: com.powsybl.ucte.converter
Module: com.powsybl.ucte.converter

Other information:
This PR breaks all the projects depending on this framework: PR related to the packaging changes must be merged at the same time as this one.

@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage decreased (-0.003%) to 81.357% when pulling 09d853e on change_package_for_converters into fd76841 on master.

@miovd miovd changed the title [WIP] Change packaging for converters Change packaging for converters Mar 27, 2019
@miovd miovd changed the title Change packaging for converters [WIP] Change packaging for converters Mar 27, 2019
@miovd miovd changed the title [WIP] Change packaging for converters Change packaging for converters Mar 27, 2019
@miovd miovd force-pushed the change_package_for_converters branch from 50ccb83 to c3b0349 Compare March 27, 2019 12:52
@miovd miovd changed the title Change packaging for converters [WIP] Change packaging for converters Mar 29, 2019
@miovd miovd added the Breaking Change API is broken label Apr 3, 2019
@miovd miovd force-pushed the change_package_for_converters branch from c3b0349 to 335c46d Compare April 16, 2019 11:31
@miovd miovd force-pushed the change_package_for_converters branch from 335c46d to 626ae63 Compare April 24, 2019 08:39
@miovd miovd force-pushed the change_package_for_converters branch from fa25e70 to 3c0f063 Compare May 13, 2019 16:30
miovd added 8 commits May 16, 2019 15:03
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
…m.xml)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd force-pushed the change_package_for_converters branch from 3c0f063 to 63e9d9e Compare May 16, 2019 13:44
miovd added a commit to powsybl/powsybl-gse that referenced this pull request May 16, 2019
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd added a commit to powsybl/powsybl-incubator that referenced this pull request May 17, 2019
…re#717)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd closed this Jun 17, 2019
@miovd miovd deleted the change_package_for_converters branch November 4, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iidm-api and iidm-converter-api modules merging
2 participants