BBranch calculated connectable bus from NB view can be null #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
geofjamg
reviewed
Nov 8, 2019
| @@ -401,8 +401,8 @@ BusExt getConnectableBus(int node) { | |||
| // if nothing found, just take the first bus | |||
| if (connectableBus2[0] == null) { | |||
| Iterator<CalculatedBus> it = getBuses().iterator(); | |||
There was a problem hiding this comment.
I don't remember why the original check is done using iterator but as getBuses() returns a Collection it would be more clear to use isEmpty()
zamarrenolm
approved these changes
Nov 11, 2019
| @@ -401,8 +401,8 @@ BusExt getConnectableBus(int node) { | |||
| // if nothing found, just take the first bus | |||
| if (connectableBus2[0] == null) { | |||
| Iterator<CalculatedBus> it = getBuses().iterator(); | |||
Signed-off-by: Luma Zamarreño <zamarrenolm@aia.es>
geofjamg
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restfix #981
fix #939
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)