Cgmes conversion three windings transformer new API #1022

marqueslanauja · 2019-11-18T11:33:51Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
The current ThreeWindingsTransformer API only supports G and B in Leg 1 and ratioTapChanger in legs 2 or 3.

What is the new behavior (if this is a feature change)?

The new ThreeWindingsTransformer API supports G and B, ratioTapChanger and phaseTapChanger in all legs.
Only one tapChanger regulating is allowed.
A warning is written if there are a ratioTapChanger and a phaseTapChanger on the leg.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

…(step 1: generators) Signed-off-by: Luma Zamarreño <zamarrenolm@aia.es>

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Signed-off-by: José Antonio Marqués <marquesja@aia.es> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMapping.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForGenerators.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForTransformers.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/ExternalNetworkInjectionConversion.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/PhaseTapChangerConversion.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/RatioTapChangerConversion.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/SynchronousMachineConversion.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/TwoWindingsTransformerConversion.java

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

… enabled. Signed-off-by: José Antonio Marqués <marquesja@aia.es>

…rsion_svcRegulatingControl Signed-off-by: José Antonio Marqués <marquesja@aia.es> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMapping.java # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/elements/StaticVarCompensatorConversion.java

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

…rsion_svcRegulatingControl

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

…rsion_regulatingControlUniformization Signed-off-by: José Antonio Marqués <marquesja@aia.es> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/PhaseTapChangerParent.java

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java

...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerAdderImpl.java

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

marqueslanauja · 2019-11-26T11:12:17Z

Don't forget to document the breaking change in the Migration guide

Breaking change has been documented in the Migration guide V3.1.0

Signed-off-by: José Antonio Marqués <marquesja@aia.es> # Conflicts: # iidm/iidm-mergingview/src/main/java/com/powsybl/iidm/mergingview/Leg2or3Adapter.java # iidm/iidm-mergingview/src/main/java/com/powsybl/iidm/mergingview/LegAdapter.java # iidm/iidm-mergingview/src/main/java/com/powsybl/iidm/mergingview/ThreeWindingsTransformerAdapter.java

marqueslanauja · 2019-11-26T11:56:40Z

Three windings transformer documentation under the Funtional documentation/Grid Modeling section has been updated in the PR powsybl/powsybl.github.io#103

...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerAdderImpl.java

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

… windings transformers Signed-off-by: Luma Zamarreño <zamarrenolm@aia.es>

marqueslanauja and others added 30 commits October 1, 2019 10:57

Refact generator regulating control

6abc109

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Refac generator regulating control

d28f317

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Merge branch 'master' into cgmes_conversion_generatorRegulatingControl

c6b668c

refact generator regulating control

0d63860

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Refact generator regulating control

778f8cf

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

reformatted

f41dfd2

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Organize code in separate modules for regulating controls conversion …

e6e9d3d

…(step 1: generators) Signed-off-by: Luma Zamarreño <zamarrenolm@aia.es>

Delete old class

a86c631

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Two windings tranformer regulating control refactoring

490eb67

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Two windings transformer regulating control refactoring

bcbaa19

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Three windings transformers regulating control refactoring

0e1da90

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Static Var Compensator Regulating Control refactoring

fc2aa56

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Merge master into branch T3xRegulatingControl

ef1aeeb

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Merge branch 'master' into cgmes_conversion_T3xRegulatingControl

0bba422

Warning message

9fcdf8f

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Sonar Fixes

a019a75

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Unitary test: three windings transformer with two regulating controls…

7ce822a

… enabled. Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Reviewer comments

d92bee3

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Merge branch 'master' into cgmes_conversion_T3xRegulatingControl

93e7a96

Merge branch 'cgmes_conversion_T3xRegulatingControl' into cgmes_conve…

d85b294

…rsion_svcRegulatingControl

CorrectlySet adjustments

eaab7bf

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Fix hasCorrectlySet

33680f2

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Fix correctlySet

2360b88

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

initialize: uniformization

54768bc

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

class names and method names: uniformization

0d9569d

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Reviewer comments, merge some methods

e15f7f8

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Merge branch 'master' into cgmes_conversion_T3xRegulatingControl

d4f4e4f

marqueslanauja added 4 commits November 19, 2019 12:17

add more tests to increase coverage

a5fea4d

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Pretty method name

e7ab84e

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Apply reviewer comments

3946ee7

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

add xml test for a three windings transformer with all tap changers

a94c9f8

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

miovd added PR: review-ongoing and removed PR: waiting-for-correction labels Nov 19, 2019

miovd self-requested a review November 19, 2019 16:40

Discard xml changes to keep compatibility

5232c3a

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

miovd requested changes Nov 21, 2019

View reviewed changes

miovd added PR: waiting-for-correction and removed PR: review-ongoing labels Nov 21, 2019

marqueslanauja added 2 commits November 22, 2019 08:34

Apply reviewer comments

f655b64

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

Update Three Windings Transformer javadoc

746f0b6

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

zamarrenolm approved these changes Nov 26, 2019

View reviewed changes

marqueslanauja closed this Nov 26, 2019

marqueslanauja reopened this Nov 26, 2019

miovd requested changes Nov 27, 2019

View reviewed changes

...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerAdderImpl.java Outdated Show resolved Hide resolved

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java Outdated Show resolved Hide resolved

Apply reviewer comments

d21bec0

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

miovd removed the Doc needed label Nov 27, 2019

miovd approved these changes Nov 27, 2019

View reviewed changes

zamarrenolm and others added 2 commits November 29, 2019 11:43

warn if both Ratio and Phase Tap Changer are present in two and three…

fb38345

… windings transformers Signed-off-by: Luma Zamarreño <zamarrenolm@aia.es>

Merge branch 'master' into cgmes_conversion_T3x

6c0cf3e

annetill added PR: ready-to-be-merged and removed PR: waiting-for-correction labels Nov 29, 2019

annetill merged commit 91259a2 into master Dec 2, 2019

mathbagu deleted the cgmes_conversion_T3x branch February 12, 2020 11:46

mathbagu mentioned this pull request Mar 3, 2020

[IIDM v1.0] New three windings transformer API powsybl/powsybl-iidm4cpp#22

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cgmes conversion three windings transformer new API #1022

Cgmes conversion three windings transformer new API #1022

marqueslanauja commented Nov 18, 2019

marqueslanauja commented Nov 26, 2019

marqueslanauja commented Nov 26, 2019

Cgmes conversion three windings transformer new API #1022

Cgmes conversion three windings transformer new API #1022

Conversation

marqueslanauja commented Nov 18, 2019

marqueslanauja commented Nov 26, 2019

marqueslanauja commented Nov 26, 2019