Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoWindings and ThreeWindings new Cgmes conversion #1066

Merged
merged 224 commits into from
Jan 14, 2020
Merged
Show file tree
Hide file tree
Changes from 220 commits
Commits
Show all changes
224 commits
Select commit Hold shift + click to select a range
6abc109
Refact generator regulating control
marqueslanauja Oct 1, 2019
d28f317
Refac generator regulating control
marqueslanauja Oct 2, 2019
c6b668c
Merge branch 'master' into cgmes_conversion_generatorRegulatingControl
marqueslanauja Oct 2, 2019
0d63860
refact generator regulating control
marqueslanauja Oct 2, 2019
778f8cf
Refact generator regulating control
marqueslanauja Oct 2, 2019
f41dfd2
reformatted
marqueslanauja Oct 2, 2019
e6e9d3d
Organize code in separate modules for regulating controls conversion …
zamarrenolm Oct 2, 2019
a86c631
Delete old class
marqueslanauja Oct 2, 2019
490eb67
Two windings tranformer regulating control refactoring
marqueslanauja Oct 5, 2019
bcbaa19
Two windings transformer regulating control refactoring
marqueslanauja Oct 5, 2019
0e1da90
Three windings transformers regulating control refactoring
marqueslanauja Oct 6, 2019
fc2aa56
Static Var Compensator Regulating Control refactoring
marqueslanauja Oct 7, 2019
4d65594
Merge branch 'master' into cgmes_conversion_T3xRegulatingControl
marqueslanauja Oct 25, 2019
ef1aeeb
Merge master into branch T3xRegulatingControl
marqueslanauja Oct 25, 2019
0bba422
Merge branch 'master' into cgmes_conversion_T3xRegulatingControl
marqueslanauja Oct 28, 2019
9fcdf8f
Warning message
marqueslanauja Oct 28, 2019
a019a75
Sonar Fixes
marqueslanauja Oct 28, 2019
7ce822a
Unitary test: three windings transformer with two regulating controls…
marqueslanauja Oct 28, 2019
4cf92c1
Merge branch 'cgmes_conversion_T3xRegulatingControl' into cgmes_conve…
marqueslanauja Oct 29, 2019
d92bee3
Reviewer comments
marqueslanauja Oct 29, 2019
93e7a96
Merge branch 'master' into cgmes_conversion_T3xRegulatingControl
marqueslanauja Oct 29, 2019
d85b294
Merge branch 'cgmes_conversion_T3xRegulatingControl' into cgmes_conve…
marqueslanauja Oct 29, 2019
eaab7bf
CorrectlySet adjustments
marqueslanauja Oct 29, 2019
33680f2
Fix hasCorrectlySet
marqueslanauja Oct 29, 2019
8df2c40
Merge branch 'cgmes_conversion_svcRegulatingControl' into cgmes_conve…
marqueslanauja Oct 29, 2019
2360b88
Fix correctlySet
marqueslanauja Oct 29, 2019
54768bc
initialize: uniformization
marqueslanauja Oct 29, 2019
0d9569d
class names and method names: uniformization
marqueslanauja Oct 29, 2019
e15f7f8
Reviewer comments, merge some methods
marqueslanauja Oct 29, 2019
d4f4e4f
Merge branch 'master' into cgmes_conversion_T3xRegulatingControl
marqueslanauja Oct 29, 2019
26898a8
Add phaseAngleClock to twoWindingsTransformer as an extension
marqueslanauja Oct 30, 2019
2c2389f
Merge branch 'master' into cgmes_conversion_T3xRegulatingControl
marqueslanauja Oct 30, 2019
cc55214
Only one regulating control enabled
marqueslanauja Nov 4, 2019
21180fa
Delete unnecessary code
marqueslanauja Nov 4, 2019
bc1daa4
Merge branch 'cgmes_conversion_T3xRegulatingControl' into cgmes_conve…
marqueslanauja Nov 4, 2019
ffd36da
Merge branch 'cgmes_conversion_svcRegulatingControl' into cgmes_conve…
marqueslanauja Nov 4, 2019
eb1e264
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 4, 2019
fb5331d
Test adjustments (Now only one regulating control enabled is allowed)
marqueslanauja Nov 4, 2019
be8dc55
PhaseTapChanger. Fix regulationMode - Regulating
marqueslanauja Nov 4, 2019
95ecd7b
Merge branch 'master' into cgmes_conversion_svcRegulatingControl
marqueslanauja Nov 5, 2019
0130beb
apply previous reviewer comments
marqueslanauja Nov 5, 2019
c7eea6a
Adjust warning message
marqueslanauja Nov 5, 2019
d666ca1
Merge branch 'cgmes_conversion_svcRegulatingControl' into cgmes_conve…
marqueslanauja Nov 5, 2019
8541ed2
Merge master into cgmes_conversion_regulatingControlUniformization
marqueslanauja Nov 5, 2019
2648164
merge master into cgmes_conversion_regulatingControlUniformization
marqueslanauja Nov 5, 2019
ad0c78e
Delete RegulatingControlVoltageAttributes class
marqueslanauja Nov 5, 2019
29fc313
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 5, 2019
b00330f
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 5, 2019
912e779
T3x new api
marqueslanauja Nov 6, 2019
45b5d5c
Add G and B in Legs 2 and 3
marqueslanauja Nov 7, 2019
7f5011e
Merge branch 'master' into cgmes_conversion_regulatingControlUniformi…
marqueslanauja Nov 7, 2019
477c4a6
uniformization
marqueslanauja Nov 7, 2019
d65ba09
Fix a boolean
marqueslanauja Nov 7, 2019
cfa5dbc
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 7, 2019
1a14a5b
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 7, 2019
aac234d
Set G and B in Leg2 and Leg3. Fix getLeg().getTerminal() and complete…
marqueslanauja Nov 7, 2019
9a8d527
Fix control correctly set
marqueslanauja Nov 8, 2019
9a0bfae
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 8, 2019
1f0bdda
pretty code
marqueslanauja Nov 8, 2019
8375d60
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 8, 2019
79174a8
Only one phaseAngleClock in twoWindingsTransformer
marqueslanauja Nov 8, 2019
b948c5e
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 8, 2019
f692b8d
Merge branch 'master' into cgmes_conversion_regulatingControlUniformi…
miovd Nov 11, 2019
bb37dd2
Add phaseAngleClock in ThreeWindingsTransformer as an extension
marqueslanauja Nov 11, 2019
d8e8a51
Merge branch 'cgmes_conversion_regulatingControlUniformization' into …
marqueslanauja Nov 11, 2019
1cb3a6d
Improve phaseAngleClock test
marqueslanauja Nov 11, 2019
ede90b1
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 11, 2019
d582f69
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 11, 2019
aa09e28
Merge branch 'master' into cgmes_conversion_T2x
marqueslanauja Nov 12, 2019
84c6b8d
pretty code
marqueslanauja Nov 12, 2019
f3c3edf
Test adjustment
marqueslanauja Nov 12, 2019
fa5144c
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 12, 2019
9aebb7c
ThreeWindingsTransformer: Check if there is more than one tap changer…
marqueslanauja Nov 12, 2019
4292d3d
Add the method sePhaseAngleClock in the test
marqueslanauja Nov 12, 2019
b8751a0
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 12, 2019
c77d417
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 12, 2019
9007f2c
Add the methods setPhaseAngleClockLeg2 and setPhaseAngleClockLeg3 in …
marqueslanauja Nov 12, 2019
7b6882e
Merge branch 'master' into cgmes_conversion_T2x
marqueslanauja Nov 12, 2019
cc8306c
Rename old classes. Add new classes with minimal code.
marqueslanauja Nov 13, 2019
c766455
Apply reviewer comments
marqueslanauja Nov 13, 2019
3270c05
Merge branch 'master' into cgmes_conversion_T2x
marqueslanauja Nov 13, 2019
3a3c5e1
Merge branch 'cgmes_conversion_T2x' into cgmes_conversion_T3x
marqueslanauja Nov 13, 2019
6807699
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 13, 2019
c57edfb
extend twoWindingsTransformer phaseAngleClock reviewer comments to th…
marqueslanauja Nov 13, 2019
05de453
Fix checkStyle
marqueslanauja Nov 13, 2019
55f5588
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Nov 13, 2019
ab1b4d8
TxConversion, cgmesModel load
marqueslanauja Nov 13, 2019
57e7d42
Rename classes
marqueslanauja Nov 13, 2019
1a59282
Rename some classes
marqueslanauja Nov 14, 2019
fd85a0d
TwoWindingsTransformer and ThreeWindingsTransformer: interpreted model
marqueslanauja Nov 14, 2019
9360549
Add regulating. Pretty code
marqueslanauja Nov 14, 2019
033319a
Merge branch 'cgmes_conversion_TxConvertLoad' into cgmes_conversion_T…
marqueslanauja Nov 14, 2019
b9a0692
Fix isRegulating
marqueslanauja Nov 14, 2019
48779cf
Pretty clas names
marqueslanauja Nov 15, 2019
92b21d1
Pretty class names
marqueslanauja Nov 15, 2019
b238c82
Merge branch 'cgmes_conversion_TxConvertLoad' into cgmes_conversion_T…
marqueslanauja Nov 15, 2019
2be77f5
TwoWindingsTransformer and ThreeWindingsTransformer: convert
marqueslanauja Nov 15, 2019
b80710e
Pretty class names
marqueslanauja Nov 15, 2019
4f34cf7
Pretty names
marqueslanauja Nov 15, 2019
2250020
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Nov 15, 2019
a0c9b18
TwoWindingsTransformer and ThreeWindingsTransformer: set to IIDM
marqueslanauja Nov 15, 2019
cc2b5e9
Set phaseAngleClock to IIDM
marqueslanauja Nov 15, 2019
09ecf61
TwoWindingsTransformer and ThreeWindingsTransformer: RegulatingContro…
marqueslanauja Nov 15, 2019
15d88d0
Improve isSymmetrical method
marqueslanauja Nov 18, 2019
234c2aa
Fix alpha in getStepXforAsymmetrical and getStepXforSymmetrical
marqueslanauja Nov 18, 2019
a706320
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Nov 18, 2019
c2981cd
Merge branch 'cgmes_conversion_TxConversionLoad' into cgmes_conversio…
marqueslanauja Nov 18, 2019
d948a7a
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Nov 18, 2019
df6c640
Merge branch 'cgmes_conversion_TxConversionConvert' into cgmes_conver…
marqueslanauja Nov 18, 2019
ccdc679
Merge branch 'master' into cgmes_conversion_T3x
marqueslanauja Nov 18, 2019
8da1b31
Fix merging view
marqueslanauja Nov 18, 2019
de3ddef
add phaseTapChanger compare in threeWindingsTransfirmer
marqueslanauja Nov 18, 2019
80d15bd
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 18, 2019
97b23d7
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Nov 18, 2019
a0462b5
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Nov 18, 2019
1504fba
Sonar fixes
marqueslanauja Nov 18, 2019
4e16704
add new tests to increase coverage
marqueslanauja Nov 19, 2019
23a252d
Fix warning ratio and phase on the leg
marqueslanauja Nov 19, 2019
a5fea4d
add more tests to increase coverage
marqueslanauja Nov 19, 2019
e7ab84e
Pretty method name
marqueslanauja Nov 19, 2019
3946ee7
Apply reviewer comments
marqueslanauja Nov 19, 2019
a94c9f8
add xml test for a three windings transformer with all tap changers
marqueslanauja Nov 19, 2019
5232c3a
Discard xml changes to keep compatibility
marqueslanauja Nov 20, 2019
a7a6c5f
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 20, 2019
b005c34
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Nov 20, 2019
485c5b3
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Nov 20, 2019
259383e
Merge branch 'cgmes_conversion_TxConversionLoad' into cgmes_conversio…
marqueslanauja Nov 20, 2019
0788740
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Nov 20, 2019
15e0abe
Merge branch 'cgmes_conversion_TxConversionConvert' into cgmes_conver…
marqueslanauja Nov 20, 2019
9bc77db
Fix ThreeWindingsTransformer phaseAngleClock test to the current xml …
marqueslanauja Nov 20, 2019
d841e61
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Nov 20, 2019
b55a237
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Nov 20, 2019
7c806b8
Merge branch 'cgmes_conversion_TxConversionLoad' into cgmes_conversio…
marqueslanauja Nov 20, 2019
4b3d343
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Nov 20, 2019
b656cf8
Merge branch 'cgmes_conversion_TxConversionConvert' into cgmes_conver…
marqueslanauja Nov 20, 2019
ad9fd77
TwoWindingsTransformer and ThreeWindingsTransformer instead of Connec…
marqueslanauja Nov 20, 2019
13b2f2b
cast unnecessary
marqueslanauja Nov 21, 2019
83fd97f
Extend some methods to all tap changers of the threeWindingsTransformer
marqueslanauja Nov 21, 2019
782a400
Do not discard the tapChanger if tapPosition is outside limits. An ex…
marqueslanauja Nov 21, 2019
6d0257c
warning when a tapChanger is fixed
marqueslanauja Nov 22, 2019
f655b64
Apply reviewer comments
marqueslanauja Nov 22, 2019
746f0b6
Update Three Windings Transformer javadoc
marqueslanauja Nov 25, 2019
fa25c8b
Merge branch 'master' into cgmes_conversion_T3x
marqueslanauja Nov 26, 2019
d21bec0
Apply reviewer comments
marqueslanauja Nov 27, 2019
fb38345
warn if both Ratio and Phase Tap Changer are present in two and three…
zamarrenolm Nov 29, 2019
26d7404
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Nov 29, 2019
dad38b9
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Nov 29, 2019
987d2d5
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Nov 29, 2019
df50471
Merge branch 'cgmes_conversion_TxConversionLoad' into cgmes_conversio…
marqueslanauja Nov 29, 2019
d186de5
PhaseAngleClock adjustment
marqueslanauja Nov 29, 2019
f101794
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Nov 29, 2019
8f966dc
PhaseAngleClock adjustment
marqueslanauja Nov 29, 2019
a7c3982
Merge branch 'cgmes_conversion_TxConversionConvert' into cgmes_conver…
marqueslanauja Nov 29, 2019
a6902f0
PhaseAngleClock adjustments
marqueslanauja Nov 29, 2019
6c0cf3e
Merge branch 'master' into cgmes_conversion_T3x
annetill Nov 29, 2019
b009b31
Merge branch 'cgmes_conversion_T3x' into cgmes_conversion_T3xPhaseAng…
marqueslanauja Dec 2, 2019
3ec7b19
Merge branch 'master' into cgmes_conversion_T3xPhaseAngleClock
marqueslanauja Dec 2, 2019
453a88f
PhaseAngleClock, resource adjustment
marqueslanauja Dec 2, 2019
cd0f516
Merge branch 'cgmes_conversion_T3xPhaseAngleClock' into cgmes_convers…
marqueslanauja Dec 2, 2019
a228426
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Dec 3, 2019
5a976f2
Merge branch 'cgmes_conversion_TxConversionLoad' into cgmes_conversio…
marqueslanauja Dec 3, 2019
ddf174b
Merge branch 'cgmes_conversion_TxConversionInterpret' into cgmes_conv…
marqueslanauja Dec 3, 2019
58b0944
Merge branch 'cgmes_conversion_TxConversionConvert' into cgmes_conver…
marqueslanauja Dec 3, 2019
c579ee8
Loadflow validation and loadflow resultscompletion adjustments
marqueslanauja Dec 4, 2019
56c628e
Merge branch 'master' into cgmes_conversion_fixAlpha
marqueslanauja Dec 4, 2019
f7b26d0
Use alphaRatio to clarify the code
marqueslanauja Dec 4, 2019
2d50a58
Symmetrical and Asymmetrical phaseTapChanger refactorization
marqueslanauja Dec 5, 2019
3c2899f
Update Copyright
marqueslanauja Dec 5, 2019
2fcd3b7
Xfmr2RatioPhaseRtc should be Xfmr2RatioPhaseX
marqueslanauja Dec 5, 2019
43d8c48
Xfmr2 only one negate. Add negate to Xfmr3. Delete Rtc option in rati…
marqueslanauja Dec 5, 2019
128fbae
Delete unnecessary functions
marqueslanauja Dec 5, 2019
d9ad17a
Verify interpretation for the location of CGMES tap changers relative…
zamarrenolm Dec 5, 2019
d8f230e
Merge branch 'master' into cgmes_conversion_fixAlpha
zamarrenolm Dec 5, 2019
b35aef1
undo last commit
marqueslanauja Dec 5, 2019
062a1a6
Merge branch 'cgmes_conversion_TxConversionSet' into cgmes_conversion…
marqueslanauja Dec 5, 2019
daf66e4
Merge branch 'master' into cgmes_conversion_fixAlpha
marqueslanauja Dec 9, 2019
0abce8b
Fix method names
marqueslanauja Dec 9, 2019
525ae11
Merge branch 'master' into cgmes_conversion_fixAlpha
annetill Dec 9, 2019
b49dc11
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Dec 9, 2019
25ae845
Merge branch 'master' into cgmes_conversion_fixAlpha
annetill Dec 9, 2019
729cf2b
Merge branch 'cgmes_conversion_fixAlpha' into cgmes_conversion_TxConv…
marqueslanauja Dec 9, 2019
e295fea
current conversion uses configuration for considering phase angle clock
zamarrenolm Dec 9, 2019
346990a
Set deprecated functions
marqueslanauja Dec 9, 2019
0bfd111
compare buses between networks taking into account calculated buses (…
zamarrenolm Dec 9, 2019
f565d6a
compare buses between networks taking into account calculated buses: …
zamarrenolm Dec 9, 2019
fced7c8
Revert "compare buses between networks taking into account calculated…
zamarrenolm Dec 9, 2019
fb243f2
check same identifiers instead of ensuring equivalent objects
zamarrenolm Dec 9, 2019
92c3e40
Identifiables may be null
zamarrenolm Dec 9, 2019
5bd660d
Compare current conversion and new conversion. JavaDoc interpretation…
marqueslanauja Dec 9, 2019
4047f9d
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Dec 10, 2019
b00e587
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Dec 10, 2019
552cc33
Delete unnecessary whiteSpace changes
marqueslanauja Dec 10, 2019
8df8b7b
consider PhaseTapChangerLinear to keep conversion identical to previo…
zamarrenolm Dec 10, 2019
f65d7b0
Allow PhaseTapChangerTablePoint without angle attribute
zamarrenolm Dec 10, 2019
4871583
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Dec 10, 2019
d5b0b2c
Improve and fix configuration of alternatives
marqueslanauja Dec 10, 2019
36d35ef
flows on 3-windings transformer: take into account ratio tap changer …
zamarrenolm Dec 11, 2019
64afaba
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Dec 11, 2019
3015035
additional tests; avoid static flag to select between current/new tra…
zamarrenolm Dec 11, 2019
f995714
Fix step adjustment in TwtData
marqueslanauja Dec 12, 2019
5469948
Merge branch 'master' into cgmes_conversion_TxConversion
miovd Dec 16, 2019
cbbc3e4
Delete profiling
miovd Dec 16, 2019
cd6aa04
keep angle required in phase tap changer table point, following standard
zamarrenolm Dec 16, 2019
5d62588
Modify the code according to the reviewer comments
marqueslanauja Dec 18, 2019
3233c29
Review method modifiers. Fix some to private and static.
marqueslanauja Dec 19, 2019
a391d43
structuralRatio instead of ratio0 to be more understable
marqueslanauja Dec 19, 2019
398d269
Delete all conversion code associated with phaseAngleClock
marqueslanauja Dec 19, 2019
a0c1e52
Do the shunt admittance conversion at the convert stage.
marqueslanauja Dec 19, 2019
3122c7f
reorganize code to enhance readability
zamarrenolm Dec 19, 2019
d94ca7d
Review and initial documentation of conversion methods to enhance rea…
marqueslanauja Dec 20, 2019
02162ec
Xfmr2ShuntInterpretationAlternative: Fix END1_END2 as default
marqueslanauja Dec 20, 2019
3ecccf8
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Dec 23, 2019
5a0b075
Fix ShuntAdmittance bug in BranchData and TwtData. Test adjustments.
marqueslanauja Dec 23, 2019
6d9611f
Merge branch 'master' into cgmes_conversion_TxConversion
annetill Dec 30, 2019
1934c5e
Delete xfmr2PhaseNegate and xfmr3PhaseNegate alternatives
marqueslanauja Jan 10, 2020
46efaaa
CgmesT2xModel, InterpretedT2xModel, ConvertedT2xModel, CgmesT3xModel,…
marqueslanauja Jan 12, 2020
a05da51
Merge branch 'master' into cgmes_conversion_TxConversion
marqueslanauja Jan 12, 2020
e023f0c
Reduce duplicated code
marqueslanauja Jan 12, 2020
0311627
Delete unnecessary code
marqueslanauja Jan 12, 2020
9caa343
Merge branch 'master' into cgmes_conversion_TxConversion
annetill Jan 13, 2020
f1d8ae0
Apply reviewer comments
marqueslanauja Jan 13, 2020
f83f3b1
Fix code smells
miovd Jan 13, 2020
63b7395
Fix code smells (bis)
miovd Jan 14, 2020
5589097
Merge branch 'master' into cgmes_conversion_TxConversion
miovd Jan 14, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ private Conversion.Config config(Properties p) {
getFormat(),
p,
STORE_CGMES_CONVERSION_CONTEXT_AS_NETWORK_EXTENSION_PARAMETER,
defaultValueConfig))
.setUseNewTransformerConversion(
ConversionParameters.readBooleanParameter(
getFormat(),
p,
TEMP_USE_NEW_TRANSFORMER_CONVERSION_PARAMETER,
defaultValueConfig));
}

Expand Down Expand Up @@ -289,6 +295,11 @@ private void copyStream(ReadOnlyDataSource from, DataSource to, String fromName,
"Store the initial CGMES model as a network extension",
Boolean.TRUE)
.addAdditionalNames("storeCgmesModelAsNetworkExtension");
private static final Parameter TEMP_USE_NEW_TRANSFORMER_CONVERSION_PARAMETER = new Parameter(
"tempUseNewTransformerConversion",
ParameterType.BOOLEAN,
"Temporal parameter to configure which version of transformer conversion to use",
Boolean.TRUE);

private static final List<Parameter> STATIC_PARAMETERS = ImmutableList.of(
ALLOW_UNSUPPORTED_TAP_CHANGERS_PARAMETER,
Expand All @@ -299,7 +310,8 @@ private void copyStream(ReadOnlyDataSource from, DataSource to, String fromName,
POST_PROCESSORS_PARAMETER,
POWSYBL_TRIPLESTORE_PARAMETER,
STORE_CGMES_CONVERSION_CONTEXT_AS_NETWORK_EXTENSION_PARAMETER,
STORE_CGMES_MODEL_AS_NETWORK_EXTENSION_PARAMETER);
STORE_CGMES_MODEL_AS_NETWORK_EXTENSION_PARAMETER,
TEMP_USE_NEW_TRANSFORMER_CONVERSION_PARAMETER);

private final Parameter boundaryLocationParameter;
private final Map<String, CgmesImportPostProcessor> postProcessors;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
import com.powsybl.cgmes.conversion.Conversion.Config;
import com.powsybl.cgmes.conversion.elements.ACLineSegmentConversion;
import com.powsybl.cgmes.model.CgmesModel;
import com.powsybl.cgmes.model.CgmesNames;
import com.powsybl.cgmes.model.PowerFlow;
import com.powsybl.iidm.network.ConnectableType;
import com.powsybl.iidm.network.Network;
import com.powsybl.iidm.network.Terminal;
import com.powsybl.triplestore.api.PropertyBag;
import com.powsybl.triplestore.api.PropertyBags;

/**
Expand Down Expand Up @@ -48,8 +50,12 @@ public Context(CgmesModel cgmes, Config config, Network network) {
currentLimitsMapping = new CurrentLimitsMapping(this);
regulatingControlMapping = new RegulatingControlMapping(this);
nodeMapping = new NodeMapping();

ratioTapChangerTables = new HashMap<>();
phaseTapChangerTables = new HashMap<>();
reactiveCapabilityCurveData = new HashMap<>();
powerTransformerRatioTapChangers = new HashMap<>();
powerTransformerPhaseTapChangers = new HashMap<>();
}

public CgmesModel cgmes() {
Expand Down Expand Up @@ -143,6 +149,28 @@ public PropertyBags reactiveCapabilityCurveData(String curveId) {
return reactiveCapabilityCurveData.get(curveId);
}

public void loadRatioTapChangers() {
cgmes.ratioTapChangers().forEach(ratio -> {
String id = ratio.getId(CgmesNames.RATIO_TAP_CHANGER);
powerTransformerRatioTapChangers.put(id, ratio);
});
}

public PropertyBag ratioTapChanger(String id) {
return powerTransformerRatioTapChangers.get(id);
}

public void loadPhaseTapChangers() {
cgmes.phaseTapChangers().forEach(phase -> {
String id = phase.getId(CgmesNames.PHASE_TAP_CHANGER);
powerTransformerPhaseTapChangers.put(id, phase);
});
}

public PropertyBag phaseTapChanger(String id) {
return powerTransformerPhaseTapChangers.get(id);
}

public void loadRatioTapChangerTables() {
PropertyBags rtcpoints = cgmes.ratioTapChangerTablesPoints();
if (rtcpoints == null) {
Expand All @@ -154,10 +182,25 @@ public void loadRatioTapChangerTables() {
});
}

public void loadPhaseTapChangerTables() {
PropertyBags ptcpoints = cgmes.phaseTapChangerTablesPoints();
if (ptcpoints == null) {
return;
}
ptcpoints.forEach(p -> {
String tableId = p.getId("PhaseTapChangerTable");
phaseTapChangerTables.computeIfAbsent(tableId, tid -> new PropertyBags()).add(p);
});
}

public PropertyBags ratioTapChangerTable(String tableId) {
return ratioTapChangerTables.get(tableId);
}

public PropertyBags phaseTapChangerTable(String tableId) {
return phaseTapChangerTables.get(tableId);
}

public void startLinesConversion() {
countLines = 0;
countLinesWithSvPowerFlowsAtEnds = 0;
Expand Down Expand Up @@ -222,7 +265,10 @@ public void missing(String what, double defaultValue) {
private final RegulatingControlMapping regulatingControlMapping;

private final Map<String, PropertyBags> ratioTapChangerTables;
private final Map<String, PropertyBags> phaseTapChangerTables;
private final Map<String, PropertyBags> reactiveCapabilityCurveData;
private final Map<String, PropertyBag> powerTransformerRatioTapChangers;
private final Map<String, PropertyBag> powerTransformerPhaseTapChangers;

private int countLines;
private int countLinesWithSvPowerFlowsAtEnds;
Expand Down
Loading