Support writing IIDM-XML network extensions in previous versions #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
changed the title
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
force-pushed
the
write_network_ext_versioning
branch
from
7b9569c
to
3bcf990
Compare
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
mathbagu
reviewed
Feb 19, 2020
iidm/iidm-converter-api/src/main/java/com/powsybl/iidm/export/ExportOptions.java
Outdated
Show resolved
Hide resolved
|
Could please add:
|
…on exists before writing Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
added
PR: corrected
PR: waiting-for-review
and removed
PR: waiting-for-correction
labels
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
mathbagu
reviewed
Feb 24, 2020
commons/src/main/java/com/powsybl/commons/extensions/ExtensionXmlSerializer.java
Outdated
Show resolved
Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/NetworkXml.java
Show resolved
Hide resolved
agnesLeroy
reviewed
Feb 24, 2020
...n/java/com/powsybl/iidm/xml/extensions/AbstractVersionableNetworkExtensionXmlSerializer.java
Show resolved
Hide resolved
agnesLeroy
reviewed
Feb 24, 2020
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/XMLExporter.java
Show resolved
Hide resolved
agnesLeroy
reviewed
Feb 24, 2020
...xml-converter/src/test/java/com/powsybl/iidm/xml/IdentifiableExtensionXmlSerializerTest.java
Outdated
Show resolved
Hide resolved
agnesLeroy
reviewed
Feb 24, 2020
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
agnesLeroy
approved these changes
Feb 24, 2020
mathbagu
reviewed
Feb 25, 2020
| public void testThrowErrorUncompatibleExtensionVersion() { | ||
| public void testNotLatestVersionTerminalExtension() throws IOException { | ||
| // import XIIDM file with loadMock v1.2 | ||
| Network network = NetworkXml.read(getClass().getResourceAsStream("/V1_1/eurostag-tutorial-example1-with-loadMockExt-1_2.xml")); |
There was a problem hiding this comment.
Should you use getVersionDir(IidmXmlVersion.V1_1) also there?
Maybe we should introduce a method somewhere to get a network resource based on a version and a filename:
InputStream getNetworkAsStream(String filename, IidmVersion version) {
return getClass().getResourceAsStream(version + "/" + filename);
}
There was a problem hiding this comment.
Yes, I will make the change you suggested and introduce the new method in a new PR to prevent confusion in this one.
iidm/iidm-converter-api/src/main/java/com/powsybl/iidm/export/ExportOptions.java
Show resolved
Hide resolved
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
added
PR: ready-to-be-merged
and removed
PR: corrected
PR: waiting-for-review
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Network extensions can only be serialized in their latest version.
What is the new behavior (if this is a feature change)?
A user can choose the version in which they want to serialize their network extensions.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No