Fix calculated/merged bus name #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
mathbagu
requested changes
Feb 11, 2020
| @@ -254,7 +254,8 @@ private void updateCache() { | |||
| }, encountered); | |||
| if (isBusValid(busSet)) { | |||
| String mergedBusId = BusBreakerVoltageLevel.this.id + "_" + busNum++; | |||
| MergedBus mergedBus = new MergedBus(mergedBusId, busSet); | |||
| String mergedBusName = BusBreakerVoltageLevel.this.name != null ? BusBreakerVoltageLevel.this.name + "_" + busNum++ : null; | |||
There was a problem hiding this comment.
It seems you increment the busNum twice: the first time to generate the busId, the second time for the busName.
I think you should use busNum without increment there.
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mathbagu
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Calculated buses in node/breaker view and merged buses in bus/breaker view are not named correctly. Calculated/merged bus name is based on voltage level id like their ids but are not based on voltage level name.
What is the new behavior (if this is a feature change)?
If voltage level name exists, calculated/merged bus name is derived from it. If voltage level name does not exist, name is set to null.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)