Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete multi-files mode of XIIDM import/export #1215

Merged
merged 11 commits into from
Mar 23, 2020
Merged

Delete multi-files mode of XIIDM import/export #1215

merged 11 commits into from
Mar 23, 2020

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 10, 2020 •
edited
Loading

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Delete multi-files mode of XIIDM import/export: its usefulness is not significant enough regarding the performance regression it introduces.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

@miovd miovd added Breaking Change API is broken XIIDM Deprecated Methods have been deprecated labels Mar 10, 2020
@miovd miovd changed the title [WIP] Separate multi-files mode of XIIDM import/export in another module [WIP] Delete multi-files mode of XIIDM import/export in another module Mar 10, 2020
@miovd miovd changed the title [WIP] Delete multi-files mode of XIIDM import/export in another module [WIP] Delete multi-files mode of XIIDM import/export Mar 10, 2020
@miovd miovd changed the title [WIP] Delete multi-files mode of XIIDM import/export Delete multi-files mode of XIIDM import/export Mar 12, 2020
@miovd miovd changed the title Delete multi-files mode of XIIDM import/export [WIP] Delete multi-files mode of XIIDM import/export Mar 12, 2020
@miovd miovd changed the title [WIP] Delete multi-files mode of XIIDM import/export Delete multi-files mode of XIIDM import/export Mar 12, 2020
@miovd miovd requested a review from mathbagu March 12, 2020 16:51
@miovd miovd changed the title Delete multi-files mode of XIIDM import/export [WIP] Delete multi-files mode of XIIDM import/export Mar 13, 2020
@miovd miovd force-pushed the separate_multi_xiidm branch 2 times, most recently from 18057e6 to 3546b07 Compare March 13, 2020 08:42
@miovd miovd changed the title [WIP] Delete multi-files mode of XIIDM import/export Delete multi-files mode of XIIDM import/export Mar 13, 2020
@miovd miovd force-pushed the separate_multi_xiidm branch 2 times, most recently from 16f715e to 4dee8c8 Compare March 13, 2020 09:56
mathbagu
mathbagu requested changes Mar 13, 2020
View reviewed changes
commons/src/main/java/com/powsybl/commons/xml/XmlUtil.java Outdated Show resolved Hide resolved
commons/src/main/java/com/powsybl/commons/xml/XmlUtil.java Outdated Show resolved Hide resolved
iidm/iidm-converter-api/src/main/java/com/powsybl/iidm/IidmImportExportMode.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/NetworkXml.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/NetworkXml.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/NetworkXml.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/NetworkXml.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/XMLExporter.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/XMLImporter.java Outdated Show resolved Hide resolved
@miovd
Move all code regarding multi-files XIIDM files in new modules
764a1e6 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Add tests + corrections
4c73185 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Revert public level of XML components
38b3d2a 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Deletion of multi-files XIIDM import/export
0eabf07 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

Add deprecated comments + correct a code smell

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

corrections

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

delete whitespace changes

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

clean

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

clean

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

delete white spaces

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

corrections

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

delete unused field

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

correct checkstyle

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Revert XmlUtil mutualization
9959afe 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Revert order change in IidmImportExportMode
f9ffecb 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Refactoring XmlImporter and XmlExporter for options creations
72f2112 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Do not deprecate read(Path, ImportOptions) and validateAndRead(Path, …
0d534f7 
…ImportOptions)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd
Rename validateWithoutExtensions as validate and delete validation wi…
7adb7d0 
…thout extensions (never used)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd requested a review from mathbagu March 18, 2020 13:31
@miovd
Revert changes commons/pom.xml
f010624 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd added this to PR in progress in Evolutions IIDM via automation Mar 18, 2020
@miovd miovd mentioned this pull request Mar 18, 2020
Merged
2 tasks
@miovd miovd removed the Doc needed label Mar 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@mathbagu mathbagu merged commit a404676 into master Mar 23, 2020
Evolutions IIDM automation moved this from PR in progress to Merged PR Mar 23, 2020
@mathbagu mathbagu deleted the separate_multi_xiidm branch March 23, 2020 10:44
@miovd miovd mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathbagu mathbagu mathbagu approved these changes

Assignees
No one assigned
Labels
Breaking Change API is broken Deprecated Methods have been deprecated PR: ready-to-be-merged XIIDM
Projects
Evolutions IIDM
  
Merged PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miovd @mathbagu