Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert non linear shunts #1285

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Revert non linear shunts #1285

merged 3 commits into from
Apr 20, 2020

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Apr 20, 2020 •
edited
Loading

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Revert of PRs introducing new API for shunts (#1202 & #1244)

Does this PR introduce a breaking change or deprecate an API?
No, but the migration guide has to be updated as it reverts a breaking change

  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@miovd
Revert "Support XIIDM serialization/deserialization with new shunt API (
abcd796 
#1244)"

This reverts commit aec13a3.

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

# Conflicts:
#	iidm/iidm-xml-converter/src/test/resources/V1_2/LccRoundTripRef.xml
@miovd
Revert "Introduction of non linear shunt compensators (#1202)"
d1611b1 
This reverts commit 7e9d21f.

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

# Conflicts:
#	iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractShuntCompensatorTest.java
@miovd
Fix conflicts: correct loss factors values + add test for shunt.getOp…
78d32d8 
…tionalName()

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

99.1% 99.1% Coverage
0.0% 0.0% Duplication

@miovd miovd requested a review from mathbagu April 20, 2020 09:28
@miovd miovd merged commit 2610d27 into master Apr 20, 2020
@miovd miovd deleted the revert_shunt branch April 20, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathbagu mathbagu mathbagu approved these changes

Assignees
No one assigned
Labels
IIDM PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miovd @mathbagu