Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename topology network modifications #2238

Merged
merged 6 commits into from Aug 31, 2022
Merged

Rename topology network modifications #2238

merged 6 commits into from Aug 31, 2022

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Aug 16, 2022

Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
Fix #2229

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Renaming

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd added the Breaking Change API is broken label Aug 16, 2022
@miovd miovd requested review from flo-dup and geofjamg August 17, 2022 13:14
@annetill annetill changed the title Rename Topology network hypotheses with Connect instead of Attach Rename topology network modifications Aug 18, 2022
annetill and others added 2 commits August 18, 2022 19:06
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by phone with @flo-dup !

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

85.6% 85.6% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit ce78520 into main Aug 31, 2022
@miovd miovd deleted the rename_attach_hyp_connect branch August 31, 2022 12:45
colinepiloquet pushed a commit that referenced this pull request Sep 1, 2022
* Rename Topology network hypotheses with Connect instead of Attach
* Rename and improve doc.


Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Co-authored-by: Anne Tilloy <anne.tilloy@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming AttachNewLineOnLine / AttachVoltageLevelOnLine
2 participants