Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed exceptions when parsing a JSON network #2941

Merged
merged 1 commit into from Mar 19, 2024

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Mar 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

When parsing a JSON network, the thrown exceptions don't show much details.

What is the new behavior (if this is a feature change)?
The thrown exceptions contain more details when possible.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 requested a review from flo-dup March 19, 2024 16:06
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
11.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 4ae9955 into main Mar 19, 2024
6 checks passed
@flo-dup flo-dup deleted the json_parsing_detailed_exceptions branch March 19, 2024 16:28
rcourtier pushed a commit that referenced this pull request Mar 22, 2024
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants