Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dry run for network modifications #3002

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Dry run for network modifications #3002

wants to merge 22 commits into from

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented May 7, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #3001

What kind of change does this PR introduce?

Feature

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@olperr1 olperr1 added the Breaking Change API is broken label May 7, 2024
olperr1 and others added 5 commits June 10, 2024 11:38
@olperr1 @rolnico
Full dry run for NetworkModificationList
329a4bb 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 @rolnico
Better reports for full dry-run
e622e04 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@rolnico
add dryRun on NetworkModification
91d45ca 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix import
8f7d37d 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix AbstractPhaseShifterModification
332ccbe 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
first tests
34fc9b2 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add hasImpactOnNetwork and isLocalDryRunPossible on NetworkModification
aa63bc5 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix applyDryRun in NetworkModificationList
6aba0bf 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix applyDryRun in NetworkModificationList
e70f7f7 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico self-assigned this Jun 14, 2024
@rolnico
Merge branch 'refs/heads/main' into dry_run
5369c41 
# Conflicts:
#	iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/AbstractDisconnection.java
@rolnico
add coverage for BatteryModification
4924662 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage for Open/CloseSwitch
54e8e2b 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix imports
a7c3956 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage for ConnectableConnection
6a758e3 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage for ConnectGenerator
abac0f5 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage
1e042fa 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage
641ade8 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add coverage
9a9ba73 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
revert a change
3604c60 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
fix tests
5e78592 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

rolnico and others added 2 commits June 28, 2024 17:16
@rolnico
add test
1a93647 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@olperr1
Merge branch 'main' into dry_run
1f2b4cd 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rolnico rolnico

Labels
Breaking Change API is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dry runs for network modifications
3 participants
@olperr1 @annetill @rolnico