Export Network properties in XML #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
force-pushed
the
network-properties
branch
from
1a76a22
to
89b2d06
Compare
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
mathbagu
force-pushed
the
network-properties
branch
from
89b2d06
to
be110bd
Compare
geofjamg
reviewed
Jul 10, 2019
| @@ -20,6 +20,7 @@ | |||
| <xs:element name="network"> | |||
| <xs:complexType> | |||
| <xs:sequence> | |||
| <xs:element name="property" type="iidm:Property" minOccurs="0" maxOccurs="unbounded" /> | |||
There was a problem hiding this comment.
Like in the Java model, we also could have network inherit from identifiable?
There was a problem hiding this comment.
It's not possible to set the network name in the Java model (through factory), so if I make an inheritance in the XSD, there is something to fix in the Java API too. Do you want I change this too?
There was a problem hiding this comment.
The network factory would not be the best place for setting an optional attribute like name but it is surprising that there is no setName method in Identiable interface and that nobody has ever ask for it.
We can keep it as it is and see later, it is really a minor design issue.
geofjamg
approved these changes
Jul 10, 2019
miovd
approved these changes
Jul 12, 2019
niconoir
pushed a commit
that referenced
this pull request
Sep 4, 2019
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restThis PR is link to this topic
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix?
What is the current behavior? (You can also link to an open issue here)
If a network has properties, when exporting to XML, these properties are lost.
What is the new behavior (if this is a feature change)?
The properties are read/write by the XML formatter.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)