Implementation of Identifiable::getNetwork() #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadam50
changed the title
tadam50
force-pushed
the
iidm_add_getNetwork
branch
from
fbdf231
to
d2103dd
Compare
tadam50
changed the title
geofjamg
reviewed
Sep 23, 2019
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractIdentifiable.java
Show resolved
Hide resolved
mathbagu
reviewed
Sep 24, 2019
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractIdentifiable.java
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/MergedBus.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
tadam50
force-pushed
the
iidm_add_getNetwork
branch
from
d2103dd
to
650deb5
Compare
geofjamg
approved these changes
Sep 24, 2019
mathbagu
added
PR: review-ongoing
and removed
PR: waiting-for-review
PR: waiting-for-correction
labels
niconoir
pushed a commit
that referenced
this pull request
Oct 1, 2019
* Implementation for Identifiable::getNetwork() Signed-off-by: Thomas ADAM <tadam@silicom.fr>
nashousni
pushed a commit
that referenced
this pull request
Oct 9, 2019
* Implementation for Identifiable::getNetwork() Signed-off-by: Thomas ADAM <tadam@silicom.fr> Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas ADAM tadam@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adding following method into Identifiable interface:
Network getNetwork()
What is the current behavior? (You can also link to an open issue here)
Identifiable interface do not offer getter on Network used
What is the new behavior (if this is a feature change)?
Identifiable interface offer getter on Network used
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)