Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regulation in shunt (IIDM/XIIDM) #958

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Add regulation in shunt (IIDM/XIIDM) #958

merged 2 commits into from
Mar 2, 2020

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Sep 30, 2019 •
edited
Loading

Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
#900 : add regulation for shunts

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New features:

  • regulation of shunt is added (cf. http://www.powsybl.org/docs/iidm/model/shuntCompensator.html)
  • for homogenization purposes, RatioTapChanger.targetDeadband and PhaseTapChanger.targetDeadband are now mandatory when the tap changer is regulating (same behavior than shunts)
  • XIIDM serialization/deserialization of these evolutions
  • implement new utility methods in IidmXmlUtil
  • implement new utility test methods in AbstractXmlConverterTest

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki *(What changes might users need to make in their application due to this PR?)

@miovd miovd changed the title [WIP] Add regulation in shunt (IIDM/XIIDM) Add regulation in shunt (IIDM/XIIDM) Sep 30, 2019
@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 83.572% when pulling f558e80 on regulating_shunt into e967753 on master.

mathbagu
mathbagu reviewed Oct 3, 2019
View reviewed changes
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractTapChanger.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/RatioTapChangerAdderImpl.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ShuntCompensatorAdderImpl.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ShuntCompensator.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ShuntCompensatorAdderImpl.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ValidationUtil.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/ShuntXml.java Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/resources/xsd/iidm.xsd Outdated Show resolved Hide resolved
iidm/iidm-xml-converter/src/test/java/com/powsybl/iidm/xml/ShuntCompensatorXmlTest.java Outdated Show resolved Hide resolved
iidm/iidm-test/src/main/java/com/powsybl/iidm/network/test/ShuntTestCaseFactory.java Outdated Show resolved Hide resolved
@miovd miovd requested a review from mathbagu October 3, 2019 14:15
@miovd miovd changed the title Add regulation in shunt (IIDM/XIIDM) [WIP] Add regulation in shunt (IIDM/XIIDM) Dec 3, 2019
@miovd miovd added this to Merged PR in Evolutions IIDM Jan 9, 2020
@miovd miovd moved this from Merged PR to PR in progress in Evolutions IIDM Jan 9, 2020
@miovd miovd removed the request for review from geofjamg January 21, 2020 16:05
@miovd miovd changed the title Add regulation in shunt (IIDM/XIIDM) [WIP] Add regulation in shunt (IIDM/XIIDM) Feb 27, 2020
@miovd miovd changed the title [WIP] Add regulation in shunt (IIDM/XIIDM) Add regulation in shunt (IIDM/XIIDM) Feb 27, 2020
@miovd miovd changed the title Add regulation in shunt (IIDM/XIIDM) WIP Add regulation in shunt (IIDM/XIIDM) Feb 27, 2020
@miovd miovd changed the title WIP Add regulation in shunt (IIDM/XIIDM) Add regulation in shunt (IIDM/XIIDM) Feb 27, 2020
@miovd miovd force-pushed the evolution_xiidm/1.2 branch 3 times, most recently from 84c0487 to c84b8c6 Compare February 28, 2020 12:11
@miovd miovd changed the title Add regulation in shunt (IIDM/XIIDM) [WIP] Add regulation in shunt (IIDM/XIIDM) Feb 28, 2020
@miovd miovd changed the title [WIP] Add regulation in shunt (IIDM/XIIDM) Add regulation in shunt (IIDM/XIIDM) Feb 28, 2020
@miovd
Add regulation in shunt (IIDM/XIIDM)
70bea23 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
mathbagu
mathbagu approved these changes Mar 2, 2020
View reviewed changes
iidm/iidm-xml-converter/src/test/resources/V1_1/LccRoundTripRef.xml Outdated
@@ -21,7 +21,7 @@
<iidm:switch id="DISC_BBS1_BK3" name="Disconnector" kind="DISCONNECTOR" retained="false" open="false" node1="0" node2="5"/>
<iidm:switch id="BK3" name="Breaker" kind="BREAKER" retained="true" open="false" node1="5" node2="6"/>
</iidm:nodeBreakerTopology>
<iidm:shunt id="C2_Filter1" name="Filter 3" bPerSection="3.0E-5" maximumSectionCount="1" currentSectionCount="1" node="4" q="12.5"/>
<iidm:shunt id="C2_Filter1" name="Filter 3" bPerSection="3.0E-5" maximumSectionCount="1" currentSectionCount="1" node="4" q="12.5"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to have a space there. If I remember well, @annetill fixed it in a previous PR

@miovd
Correct spaces in xml test files
72cfb13 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 36c5e6f into evolution_xiidm/1.2 Mar 2, 2020
Evolutions IIDM automation moved this from PR in progress to Merged PR Mar 2, 2020
@miovd miovd deleted the regulating_shunt branch March 2, 2020 16:04
miovd added a commit that referenced this pull request Mar 2, 2020
@miovd
Add regulation in shunt (IIDM/XIIDM) (#958)
080c070 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

* Add regulation in shunt (IIDM/XIIDM)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd added a commit that referenced this pull request Mar 4, 2020
@miovd
Add regulation in shunt (IIDM/XIIDM) (#958)
7619380 
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>

* Add regulation in shunt (IIDM/XIIDM)

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
This was referenced Mar 4, 2020
Merged
Closed
This was referenced Mar 23, 2020
Closed
Closed
@mathbagu mathbagu mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yichen88 yichen88 yichen88 left review comments

@agnesLeroy agnesLeroy agnesLeroy approved these changes

@mathbagu mathbagu mathbagu approved these changes

@annetill annetill annetill approved these changes

Assignees
No one assigned
Labels
Breaking Change API is broken IIDM PR: corrected PR: waiting-for-review XIIDM
Projects
Evolutions IIDM
  
Merged PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miovd @coveralls @mathbagu @agnesLeroy @yichen88 @annetill