Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox to enable/disable substitution of internal two-winding tranformers #102

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the new behavior (if this is a feature change)?
A checkbox enables to enable/disable the substitution of internal two-winding transformers (internal meaning both ends in the same voltage level) by a voltage level equipment node. That is, choose between displaying such transformers outside the voltage level with a snake line or within an externCell/internCell

Other information:
This needs to build a snapshot of powsybl-diagram based on PR powsybl/powsybl-diagram#594

@flo-dup flo-dup changed the base branch from main to pst_filter March 13, 2024 15:30
@flo-dup flo-dup force-pushed the add_substitute_internal2wt_checkbox branch from dbd0286 to b84c14c Compare March 13, 2024 15:46
Base automatically changed from pst_filter to main March 15, 2024 21:49
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the add_substitute_internal2wt_checkbox branch from b84c14c to ef119c8 Compare March 29, 2024 13:36
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link

sonarcloud bot commented Mar 29, 2024

flo-dup and others added 3 commits April 29, 2024 09:38
This reverts commit 5e4e7ed.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link

sonarcloud bot commented Apr 29, 2024

@flo-dup flo-dup merged commit bb3bcfc into main Apr 29, 2024
4 checks passed
@flo-dup flo-dup deleted the add_substitute_internal2wt_checkbox branch April 29, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant