Update metadata and add callback for node moving in network area diagram #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
requested changes
May 30, 2024
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
requested changes
May 31, 2024
| this.onNodeCallback( | ||
| node.getAttribute('equipmentid') ?? '', | ||
| node.getAttribute('svgid') ?? '', | ||
| DiagramUtils.round(mousePosition.x, 2), |
There was a problem hiding this comment.
You'd rather reuse the exact same value as in the metadata. Just introduce a variable const xNew = DiagramUtils.getFormattedValue(mousePosition.x), and similarly for y.
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
When a node is moved in network area diagram the metadata of the node is not changed, and no callback is available for having information about the node moving
What is the new behavior (if this is a feature change)?
When a node is moved the metadata of the node is updated with the new position, and a callback has been added for having information about the node moving
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the constructor of the NetworkAreaDiagramViewer has a new additional parameter: the callback.
An example of callback is provided in the demo/src/diagram-viewers/add-diagrams.js file