Move edge names when moving edges in network area diagram #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
requested changes
Jun 11, 2024
Comment on lines
447
to
462
| const nameElement: SVGGraphicsElement = | ||
| edgeNode.lastElementChild as SVGGraphicsElement; | ||
| if ( | ||
| nameElement != null && | ||
| nameElement.tagName == 'g' && | ||
| (nameElement.id == null || nameElement.id.length == 0) | ||
| ) { | ||
| // get DOM element containing name position | ||
| const namePositionElement: SVGGraphicsElement = | ||
| nameElement.lastElementChild as SVGGraphicsElement; | ||
| if ( | ||
| namePositionElement != null && | ||
| namePositionElement.tagName == 'g' && | ||
| (namePositionElement.id == null || | ||
| namePositionElement.id.length == 0) | ||
| ) { |
There was a problem hiding this comment.
you could avoid all this with a querySelector, it would be more robust
const edgeNamePositionElement: SVGGraphicsElement =
edgeNode.querySelector(".nad-edge-label") as SVGGraphicsElement;There was a problem hiding this comment.
Used querySelector for getting the element
Comment on lines
465
to
472
| const nameAngleElement: SVGGraphicsElement = | ||
| namePositionElement.lastElementChild as SVGGraphicsElement; | ||
| if ( | ||
| nameAngleElement != null && | ||
| nameAngleElement.tagName == 'text' | ||
| ) { | ||
| edgeNameAngleElement = nameAngleElement; | ||
| } |
There was a problem hiding this comment.
similarly
const edgeNameAngleElement: SVGGraphicsElement =
edgeNamePositionElement.querySelector("text") as SVGGraphicsElement;There was a problem hiding this comment.
Used querySelector for getting the element
| anchorPoint: Point, | ||
| edgeStart: Point | ||
| ) { | ||
| const edgeNameElements = DiagramUtils.getEdgeNameElements(edgeNode); |
There was a problem hiding this comment.
as the content of DiagramUtils.getEdgeNameElements is very compact with querySelectors, I think you can remove it and call the querySelectors directly here
There was a problem hiding this comment.
Removed DiagramUtils function and used querySelector for getting the elements in this method
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
flo-dup
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In network area diagram, when moving an edge (due to the movement of a voltage level node) the edge name, if displayed, is not moved
What is the new behavior (if this is a feature change)?
When moving an edge (following the movement of a voltage level node) the edge name is correctly moved
Does this PR introduce a breaking change or deprecate an API?