Write svg in json tests for debug #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
requested review from
geofjamg and
BenoitJeanson
and removed request for
geofjamg
flo-dup
force-pushed
the
debug_write_svg_in_json_tests
branch
from
1f33ac7
to
8d33028
Compare
geofjamg
reviewed
Nov 24, 2020
| @@ -61,7 +61,7 @@ public void test() { | |||
| new BlockOrganizer().organize(g); | |||
|
|
|||
| // calculate coordinates | |||
| LayoutParameters layoutParameters = new LayoutParameters() | |||
| layoutParameters = new LayoutParameters() | |||
There was a problem hiding this comment.
Maybe not very important but it is probably a little bit weak as a design. Maybe just have an abstract LayoutParameters getLayoutParameter() in the base class?
Used for debug purposes, checking the look of the corresponding SVG Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
- Replacing all new LayoutParameters in tests by getLayoutParameters - Factorizing same LayoutParameters with createDefaultLayoutParameters() Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
debug_write_svg_in_json_tests
branch
2 times, most recently
from
0e59963
to
1ed1deb
Compare
In order to generate all svg files even if one test fails Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
debug_write_svg_in_json_tests
branch
from
1ed1deb
to
0ffc22b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
geofjamg
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
No.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
One cannot easily generate all svg files related to json reference test files (which sometimes correspond to not-so-good diagrams) to see whether the reference is ok, and when changing the reference file whether that change is not unexpectedly changing the diagram rendering.
What is the new behavior (if this is a feature change)?
If writeFile parameter is true in AbstractTestCase, all json tests inheriting from
AbstractTestCasewill generate the corresponding svg file.Does this PR introduce a breaking change or deprecate an API?
No
Other information:
Note that this had already been done by @BenoitJeanson for tests extending
AbstractTestCaseRaw, this PR simply extends this behaviour to all tests extendingAbstractTestCase