Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SA results by forcing DFL to ouputs networks after SA. #169

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

gautierbureau
Copy link
Contributor

@gautierbureau gautierbureau commented Feb 2, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
N/A

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
The SA with DynaFlow has the right results

What is the current behavior? (You can also link to an open issue here)
The results were not read because DFL did not output the network output files that are mandatory

What is the new behavior (if this is a feature change)?
We force DFL to output the network files

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@gautierbureau gautierbureau added the bug Something isn't working label Feb 2, 2023
Signed-off-by: Gautier Bureau <gautier.bureau@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 374e117 into main Feb 2, 2023
@flo-dup flo-dup deleted the fix_sa branch February 2, 2023 15:38
flo-dup added a commit that referenced this pull request Mar 10, 2023
…)"

This reverts commit 374e117.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants