Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tap changer automatons #198

Merged
merged 26 commits into from
May 5, 2023
Merged

Add tap changer automatons #198

merged 26 commits into from
May 5, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Apr 13, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add the following models :

  • LoadTwoTransformers
  • LoadOneTransformerTapChanger
  • LoadTwoTransformersTapChangers
  • TapChangerAutomaton
  • TapChangerBlockingAutomaton

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Lisrte added 14 commits April 5, 2023 13:17
@Lisrte
Replace Event disconnection in DSL with Disconnect and DisconnectQuad…
618f668 
…ripole

Handle quadripole disconnection

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add default model and quadripole disconnection for Transformer
02849d6 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Fix quadripole disconnection
6d38349 
Add UT

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Handle default & dynamic model disconnection
d837b66 
Add disconnection UT
Add default model Load

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add default model generator
f2a0c41 
Fix UT

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Merge equipment and quadripole equipment disconnection event in DSL
30aef8a 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Fix after branch update
4fc95eb 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add test coverage
9d0dc6e 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Review fix
b333430 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Refactor event constructor
d76813c 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add Load with tap changer
89e185d 
Add Tap changer blocking automaton

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Refactor Load with tap changer
8ac8af6 
Add UT

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add TapChangerAutomaton
9c6dc3d 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Add TapChangerBlockingAutomaton to TapChangerAutomaton connection
d81be5e 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte self-assigned this Apr 13, 2023
@Lisrte
Add TapChangerBlockingAutomaton libs
a11c80f 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte changed the base branch from main to refactor_disconnection_events April 18, 2023 14:34
@Lisrte
Fix copyrights
1d7f200 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the refactor_disconnection_events branch from 2ebbd29 to a322bd0 Compare April 19, 2023 14:48
@Lisrte
Fix library name
f37a192 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Fix library name 2
9f30aef 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Base automatically changed from refactor_disconnection_events to main April 21, 2023 14:14
@Lisrte
Merge branch 'main' into add_tap_changer_automatons
d9edadc 
# Conflicts:
#	dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/AbstractPureDynamicGroovyExtension.groovy
#	dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/events/EventDisconnectionGroovyExtension.groovy
#	dynawaltz-dsl/src/test/java/com/powsybl/dynawaltz/dsl/DynamicModelsSupplierTest.java
#	dynawaltz-dsl/src/test/java/com/powsybl/dynawaltz/dsl/EventModelsSupplierTest.java
#	dynawaltz-dsl/src/test/resources/ieee57-disconnectgenerator/dynawaltz-inputs/powsybl_dynawaltz.dyd
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/AbstractBlackBoxModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/DisconnectableEquipment.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/EventQuadripoleDisconnection.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/EventSetPointBoolean.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/events/QuadripoleDisconnectableEquipment.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/AbstractGeneratorModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/DefaultGeneratorModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/GeneratorModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/OmegaRefGeneratorModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/lines/StandardLine.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/loads/AbstractLoad.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/transformers/DefaultTransformerModel.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/transformers/TransformerFixedRatio.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/transformers/TransformerModel.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DisconnectEventXmlTest.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DynaWaltzTestUtil.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/DynamicModelsXmlTest.java
#	dynawaltz/src/test/java/com/powsybl/dynawaltz/xml/EventXmlTest.java
#	dynawaltz/src/test/resources/disconnect_dyd.xml
#	dynawaltz/src/test/resources/events.xml
@Lisrte
Fix merge
6a4f56a 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Fix code smells
28f6179 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Review fixes
11373c5 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Fix uMeasurement upper case
e5c4303 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte
Review fixes
1419df8 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Lisrte and others added 2 commits May 5, 2023 14:23
@Lisrte
Review fixes 2
8332b0f 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@flo-dup
Fix code smell
46c6e33 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.9% 91.9% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit d243a1c into main May 5, 2023
6 checks passed
@flo-dup flo-dup deleted the add_tap_changer_automatons branch May 5, 2023 13:26
Lisrte added a commit that referenced this pull request May 10, 2023
@Lisrte
Add tap changer automatons (#198)
04c2996 
- Add LoadTwoTransformers model
- Add LoadOneTransformerTapChanger model
- Add LoadTwoTransformersTapChangers model
- Add TapChangerAutomaton model
- Add TapChangerBlockingAutomaton model

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

Assignees

@Lisrte Lisrte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lisrte @flo-dup