Fix merging loads #213
Merged
Fix merging loads #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
geofjamg
approved these changes
Apr 24, 2023
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
Lisrte
pushed a commit
that referenced
this pull request
May 10, 2023
* Fix merging loads * Rename enum into LoadPowersSigns * LoadAdder created in LoadsToMerge constructor * Build list of loads to merge only per voltage level * Simplify code by using streams * Merge done in LoadsToMerge Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
Bug fix + refactor
What is the current behavior?
Loads are accessed after being removed, which leads in some implementations to a crash
What is the new behavior (if this is a feature change)?
Loads are not accessed once removed, and cannot be accessed in LoadsToMerge object anymore
Does this PR introduce a breaking change or deprecate an API?
No