Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active power variation #218

Merged
merged 12 commits into from
May 19, 2023
Merged

Add active power variation #218

merged 12 commits into from
May 19, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented May 4, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
Add active power variation model
Add SMIB integration test

@Lisrte Lisrte requested a review from flo-dup May 4, 2023 12:42
@Lisrte Lisrte self-assigned this May 4, 2023
Base automatically changed from add_infinite_bus to main May 19, 2023 09:29
@flo-dup flo-dup force-pushed the add_active_power_variation branch from 881c930 to dbc871f Compare May 19, 2023 11:20
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Add writeFinalState to DynaWaltzParameters

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@flo-dup flo-dup force-pushed the add_active_power_variation branch from dbc871f to abcb361 Compare May 19, 2023 11:24
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 3 Code Smells

97.6% 97.6% Coverage
0.6% 0.6% Duplication

/**
* @author Laurent Issertial <laurent.issertial at rte-france.com>
*/
abstract class AbstractConfigDynamicModelBuilder extends AbstractDynamicModelBuilder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this class as not all builders with config can inherit from it (see LoadAlphaBetaBuilder). Let's see later if we can do better.

@flo-dup flo-dup merged commit 3f6eb6c into main May 19, 2023
5 of 6 checks passed
@flo-dup flo-dup deleted the add_active_power_variation branch May 19, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants