Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Timeline dynawo file #229

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Parse Timeline dynawo file #229

merged 10 commits into from
Jun 6, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented May 25, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
Add XML and CSV parser for dynawo's timeline

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

marcosmc and others added 3 commits May 16, 2023 17:09
@marcosmc @Lisrte
TimeLine parsers
d1627a7 
Signed-off-by: Marcos de Miguel <demiguelm@aia.es>
@marcosmc @Lisrte
TimeLine resources
ad0ba90 
Signed-off-by: Marcos de Miguel <demiguelm@aia.es>
@Lisrte
Refactor Timeline parser
67968eb 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte requested a review from flo-dup May 25, 2023 15:28
@Lisrte Lisrte self-assigned this May 25, 2023
Lisrte and others added 6 commits May 26, 2023 10:30
@Lisrte
Fix code smells
d4923a4 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@flo-dup
Use Event instead of StringTimeSeries map
fcc56ef 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Rename timeseries package to timeline
333ee05 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add interface and factorize common code
0a6415b 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Rename Event to TimelineEntry
ad4b06b 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean dependencies
77af35c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 2ad5009 into main Jun 6, 2023
6 checks passed
@flo-dup flo-dup deleted the Timeline-Output branch June 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

Assignees

@Lisrte Lisrte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lisrte @flo-dup @marcosmc