Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for simplifying adding custom models #231

Merged
merged 4 commits into from
May 30, 2023
Merged

Add methods for simplifying adding custom models #231

merged 4 commits into from
May 30, 2023

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 30, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Methods are missing for adding custom models:

  • the models.cfg file cannot easily be changed
  • no custom equipment property can be added
  • some createMacroConnections methods are missing

What is the new behavior (if this is a feature change)?

  • the models.cfg file can easily be changed
  • any custom equipment property can be added as a string
  • more createMacroConnections methods are available

Does this PR introduce a breaking change or deprecate an API? yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

@flo-dup
Add AbstractGeneratorBuilder
93921ad 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
AbstractEquipmentGroovyExtension can take a config URL as parameter
94a7057 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Delete EnumEquipmentProperty to simplify adding custom properties
ff263ac 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add new utility methods for simplifying adding new models
3bf69bd 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup added the Breaking Change API is broken label May 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 874db40 into main May 30, 2023
6 checks passed
@flo-dup flo-dup deleted the for_extending_models branch May 30, 2023 20:31
@flo-dup flo-dup linked an issue Jun 9, 2023 that may be closed by this pull request
Synchronous generators config file #149
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change API is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronous generators config file
1 participant
@flo-dup