Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when model parameter set is not found in DynaWaltzParameters #310

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 14, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #248

…eters

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte requested a review from flo-dup November 14, 2023 10:08
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 00449ae into main Dec 11, 2023
6 checks passed
@flo-dup flo-dup deleted the parameter_set_not_found branch December 11, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve log in OmegaRef
2 participants