Update Network with DynaFlow results #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: janeg <janeg@aia.es>
… in dependencies. Signed-off-by: janeg <janeg@aia.es>
Signed-off-by: janeg <janeg@aia.es>
Signed-off-by: janeg <janeg@aia.es>
Signed-off-by: janeg <janeg@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es> # Conflicts: # dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowProvider.java # dynaflow/src/test/java/com/powsybl/dynaflow/DynaFlowProviderTest.java
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm
changed the title
gautierbureau
requested changes
Apr 8, 2021
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Luma <zamarrenolm@aia.es>
gautierbureau
approved these changes
Apr 12, 2021
zamarrenolm
approved these changes
Apr 12, 2021
mathbagu
requested changes
Apr 12, 2021
dynaflow/pom.xml
Outdated
| @@ -47,6 +38,11 @@ | |||
| <groupId>com.powsybl</groupId> | |||
| <artifactId>powsybl-time-series-api</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.powsybl</groupId> | |||
There was a problem hiding this comment.
Should be ${project.groupId} as powsybl-dynawo-commons is part of this repository
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright (c) 2020, RTE (http://www.rte-france.com) | |||
| * Copyright (c) 2021, RTE (http://www.rte-france.com) | |||
There was a problem hiding this comment.
The copyright date should be unchanged: this year defines the beginning of the copyright
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright (c) 2020, RTE (http://www.rte-france.com) | |||
| * Copyright (c) 2021, RTE (http://www.rte-france.com) | |||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
| /** | ||
| * @author Guillaume Pernin <guillaume.pernin at rte-france.com> | ||
| */ | ||
| public class DynaFlowProviderTest { | ||
| public class DynaFlowProviderTest extends AbstractConverterTest { |
There was a problem hiding this comment.
As we inherit from AbstractConverterTest, this class should be cleaned up: the base class provides a filesystem you should use instead of creating a new one to avoid misunderstanding behaviour
There was a problem hiding this comment.
removed local filesystem instance
Comment on lines
87
to
89
| private final String outPutIIDM; | ||
|
|
||
| public LocalCommandExecutorMock(String stdoutFileRef) { | ||
| public LocalCommandExecutorMock(String stdoutFileRef, String outPutIIDM) { |
There was a problem hiding this comment.
I think we should write outputIidm to follow the coding style.
There was a problem hiding this comment.
fixed following case convention
Signed-off-by: Luma <zamarrenolm@aia.es>
|
Kudos, SonarCloud Quality Gate passed! |
mathbagu
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
Updating results from DynaFlow not present
What is the new behavior (if this is a feature change)?
Added Update network with results coming from DynaFlow.