Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependencies #97

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Clean up dependencies #97

merged 1 commit into from
Nov 22, 2021

Conversation

zamarrenolm
Copy link
Member

Signed-off-by: Luma zamarrenolm@aia.es

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Removed dependency not required in dynaflow (time-series).
Removed dependency information for sub-modules in main pom (dynawaltz, dynawaltz-dsl).

What is the current behavior? (You can also link to an open issue here)
Dynaflow does not need to use time-series module from powsybl-core.

Other information
The unneeded dependency in dynaflow (time-series) was found when testing the integration of dynaflow in pypowsybl. Adding powsybl-dynaflow to pypowsybl forced the inclusion of Groovy in the set of java libraries being used, and that provoked an error when building the GraalVM native-image.

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm self-assigned this Nov 19, 2021
@miovd miovd merged commit ab7c3c4 into main Nov 22, 2021
@miovd miovd deleted the clean_up_poms branch November 22, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants