Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::function by template parameter #90

Open
mathbagu opened this issue Apr 30, 2020 · 0 comments
Open

Replace std::function by template parameter #90

mathbagu opened this issue Apr 30, 2020 · 0 comments
Projects

Comments

@mathbagu
Copy link

  • Do you want to request a feature or report a bug?
    Refactoring

  • What is the current behavior?
    We pass sometimes lambda expression as std::function. Sonar consider this is a bad practice, and we should pass template parameter instead. This pattern has been used in Update serialization of ThreeWindingsTransformer #87 and can be generalized.
    See sonar analysis : https://sonarcloud.io/project/issues?id=com.powsybl%3Apowsybl-iidm4cpp&resolved=false&rules=cpp%3AS5213&types=CODE_SMELL

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  • What is the expected behavior?
    No more code smells of this type

  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@mathbagu mathbagu added this to To do in IIDM v1.4.1 via automation Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant