Update serialization of ThreeWindingsTransformer #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
added
PR: waiting-for-correction
PR: waiting-for-info-author
and removed
PR: waiting-for-review
labels
mathbagu
force-pushed
the
issue-27-update-3wt-serialization
branch
from
71e0ba3
to
f33f8b9
Compare
mathbagu
force-pushed
the
integration/v1.1.0
branch
from
ee9a96c
to
4a09d60
Compare
- Fix also stdcxx::isEqual for NaN values - Fix also ratedU0 for XIIDM v1.0 Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr> Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com> Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
mathbagu
force-pushed
the
issue-27-update-3wt-serialization
branch
from
f33f8b9
to
3e67406
Compare
mathbagu
approved these changes
May 4, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#27
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It provides an update of ThreeWindingsTransformer XML serialization
What is the current behavior? (You can also link to an open issue here)
The following attributes were not written/read in iidm:threeWindingsTransformer tag : g2, b2, g3, b3 and ratedU0
What is the new behavior (if this is a feature change)?
g2, b2, g3, b3 and ratedU0 are written
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)