-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension design #102
Merged
Merged
New extension design #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalaig
commented
May 13, 2020
mathbagu
requested changes
May 13, 2020
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
ca7d04b
to
427c91c
Compare
mathbagu
reviewed
May 18, 2020
mathbagu
approved these changes
May 18, 2020
Kudos, SonarCloud Quality Gate passed!
|
mathbagu
pushed a commit
that referenced
this pull request
Jun 11, 2020
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
mathbagu
pushed a commit
that referenced
this pull request
Jun 11, 2020
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
mathbagu
pushed a commit
that referenced
this pull request
Jun 17, 2020
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien LAIGRE slaigre@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restIssue #35
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It provides an API to make easier the addition of an extension to an extendable by using an
ExtensionAdder
.What is the current behavior? (You can also link to an open issue here)
User has to call
to add the extension.
What is the new behavior (if this is a feature change)?
User can call
to add into myExtendable.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)