Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unique #81

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Check unique #81

merged 5 commits into from
Apr 20, 2020

Conversation

mathbagu
Copy link

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#20

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
It' not possible to generate automatically the ID of new identifiables, in case of ID collision.

What is the new behavior (if this is a feature change)?
It's now possible.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Mathieu BAGUE added 2 commits April 18, 2020 00:06
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@mathbagu mathbagu requested a review from sebalaig April 18, 2020 12:03
@mathbagu mathbagu added this to In progress in IIDM v1.0 via automation Apr 18, 2020
@mathbagu mathbagu moved this from In progress to Review in IIDM v1.0 Apr 18, 2020
Mathieu BAGUE added 2 commits April 18, 2020 19:37
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

62.8% 62.8% Coverage
0.0% 0.0% Duplication

@mathbagu mathbagu merged commit 057e8a3 into master Apr 20, 2020
IIDM v1.0 automation moved this from Review to Done Apr 20, 2020
@mathbagu mathbagu deleted the checkUniqueId branch April 20, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IIDM v1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants