Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph custom nodes #157

Closed
geofjamg opened this issue Sep 11, 2019 · 1 comment
Closed

Graph custom nodes #157

geofjamg opened this issue Sep 11, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request Substation diagram

Comments

@geofjamg
Copy link
Member

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    ComponentLibrary manage a set of svg associated to a node in the substation Graph thanks to enum ComponentType. If a substation diagram user wants to add a custom node with a custom rendering, there is no way to do it without forking the source code, adding a new value in the ComponentType enum, add the SVG to the ComponentLibrary and also hack the Graph class to insert the custom node.

  • What is the expected behavior?

    • replace ComponentType by a String
    • Add a plugin GraphBuildPostProcessor discovered using java.util.ServiceLoader and that would allow adding custom nodes to the graph.
  • What is the motivation / use case for changing the behavior?
    To allow projects to customize substation graph and rendering.

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@geofjamg geofjamg added enhancement New feature or request Substation diagram labels Sep 11, 2019
@FranckLecuyer FranckLecuyer self-assigned this Sep 11, 2019
@FranckLecuyer FranckLecuyer pinned this issue Sep 13, 2019
@FranckLecuyer FranckLecuyer unpinned this issue Sep 13, 2019
@geofjamg geofjamg added this to To do in Substation diagram via automation Sep 17, 2019
@geofjamg geofjamg moved this from To do to In progress in Substation diagram Sep 17, 2019
@geofjamg geofjamg moved this from In progress to To do in Substation diagram Sep 17, 2019
@FranckLecuyer FranckLecuyer moved this from To do to In progress in Substation diagram Sep 17, 2019
@geofjamg geofjamg moved this from In progress to Done in Substation diagram Sep 26, 2019
@geofjamg
Copy link
Member Author

geofjamg commented Oct 9, 2019

Solved by #168

@geofjamg geofjamg closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Substation diagram
Projects
Development

No branches or pull requests

2 participants