-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid svg components duplication #44
Comments
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Resolving conflicts Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
when parameter avoidSVGComponentsDuplication is set, is it expected that |
You're right. |
Do you want to request a feature or report a bug?
A performance improvement.
What is the current behavior?
SVG voltage level diagram is made of individual SVG components, wires and busbar sections assembled together. SVG component are copied in to final SVG, so it means that if we have 10 loads in the substation the SVG symbol of the load is duplicated 10 times.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
N/A
What is the expected behavior?
We could reduce the size of the substation SVG by using "refs/use" feature of SVG https://developer.mozilla.org/fr/docs/Web/SVG/Element/use to avoid duplicating component SVG.
This new feature has to be optional (a parameter in
LayoutParameters
), because JavaFX SVG rendering library probably (to check) don't support "refs/use".What is the motivation / use case for changing the behavior?
Reduce the SVG size and consequently increase rendering performance.
Please tell us about your environment:
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
The text was updated successfully, but these errors were encountered: