This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Smaller node for single-bus voltage level #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
force-pushed
the
smaller_vl_single_bus
branch
from
e972597
to
7603515
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce?
Feature
What is the current behavior? (You can also link to an open issue here)
Voltage levels are all of the same size (except fictitious ones)
What is the new behavior (if this is a feature change)?
Voltage levels are bigger if more than one bus
Does this PR introduce a breaking change or deprecate an API?
No
Other information:
One could think of a radius proportional to the number of buses, nonetheless this requires more code changes (expecially the forking edges)