Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Remove stroke on Nodes #81

Merged
merged 8 commits into from Jun 15, 2022
Merged

Remove stroke on Nodes #81

merged 8 commits into from Jun 15, 2022

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Jun 14, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Bus nodes have a >0 stroke width to separate the node annuli

What is the new behavior (if this is a feature change)?
Bus nodes have a 0 stroke width, the inner and outer radii being adapted

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 requested a review from flo-dup June 14, 2022 14:54
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup marked this pull request as ready for review June 15, 2022 12:38
flo-dup and others added 3 commits June 15, 2022 14:44
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit bad15b5 into main Jun 15, 2022
@flo-dup flo-dup deleted the remove_stroke_on_nodes branch June 15, 2022 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants