Check target voltage plausibility on Transformers and Shunt Compensators #1030
Conversation
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
changed the title
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
changed the title
There was a problem hiding this comment.
also:
- LfNetworkLoadingReport to be enhanced with 2 new inconsistencies counters for RTCs and Shunts, similar to generatorsWithInconsistentTargetVoltage
- warning log (see LfNetworkLoaderImpl#create)
- maybe add reports for the 3 inconsistencies (generator, rtc, shunt) ?
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowShuntTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
|
@vmouradian let's also do some cleanup and remove |
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
| if (!fixedShuntCompensators.isEmpty()) { | ||
| shunt = new LfShuntImpl(fixedShuntCompensators, network, this, false, parameters, topoConfig); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| static boolean checkVoltageRegulation(ShuntCompensator shuntCompensator, LfNetworkParameters parameters, LfNetworkLoadingReport report) { |
There was a problem hiding this comment.
"Regulation" is never used in OLF, please use "Control" -> checkVoltageControl
There was a problem hiding this comment.
Bad naming indeed, fixed in b43b026
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Adressed in 4026142 |
jeandemanged
changed the title
| @@ -843,15 +856,12 @@ private LfNetwork create(int numCC, int numSC, Network network, List<Bus> buses, | |||
| LOGGER.warn("Network {}: {} branches have been discarded because connected to same bus at both ends", | |||
| lfNetwork, report.branchesDiscardedBecauseConnectedToSameBusAtBothEnds); | |||
| } | |||
| if (report.linesWithDifferentNominalVoltageAtBothEnds > 0) { | |||
There was a problem hiding this comment.
this is dead code ... See #1030 (comment)
There was a problem hiding this comment.
I think it is a mistake @geofjamg what's happen here?
There was a problem hiding this comment.
| return LfGenerator.isTargetVoltageNotPlausible(newTargetV, minPlausibleTargetVoltage, maxPlausibleTargetVoltage); | ||
| return !VoltageControl.isTargetVoltagePlausible(newTargetV, minPlausibleTargetVoltage, maxPlausibleTargetVoltage); |
There was a problem hiding this comment.
@annetill just a note, no check on minNominalVoltageTargetVoltageCheck here, I have no idea if this is deliberate (I lack knowledge about this outerloop).
There was a problem hiding this comment.
I think we are going to wait for the issue @geofjamg . At RTE, we are using this outer loop on network without any generator connected to low nominal voltages, but it could arrived soon.
| @@ -30,8 +30,6 @@ public class LfNetworkLoadingReport { | |||
|
|
|||
| int branchesDiscardedBecauseConnectedToSameBusAtBothEnds = 0; | |||
|
|
|||
| int linesWithDifferentNominalVoltageAtBothEnds = 0; | |||
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
jeandemanged
changed the title
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Target voltage plausibility is configured via
minPlausibleTargetVoltage,maxPlausibleTargetVoltageandminNominalVoltageTargetVoltageCheckparameters.Today the check is performed only for LfGenerators (Includes generators, batteries, SVCs, HVDC VSC converters).
No check is made for 1/ transformer ratio tap changers and 2/ shunt compensators.
What is the new behavior (if this is a feature change)?
Check is made also for 1/ transformer ratio tap changers and 2/ shunt compensators.
As an extra, now the number of disabled controls is reported (instead of only logged).
Does this PR introduce a breaking change or deprecate an API?