Fix transformer voltage control outer loop AFTER GENERATOR #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
src/main/java/com/powsybl/openloadflow/ac/outerloop/TransformerVoltageControlOuterLoop.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/AbstractAcOuterLoopConfig.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
requested changes
May 30, 2024
What could be the purpose of no limit ? |
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
…m/powsybl/powsybl-open-loadflow into fix_transfo_after_voltage_control
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
…l' into fix_transfo_after_voltage_control
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Not much sense according to the algo logic, but from my experiments it works well and without convergence issues. |
vidaldid-rte
approved these changes
May 30, 2024
geofjamg
approved these changes
May 30, 2024
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No, but it occurs on real RTE network where now we have some transformers with a voltage control on 225 kV (transformers used for off shore wind farm for example). So the highest nominal voltage controlled by transformers is quite high and too high to determine which generators must have its voltage control disabled during outer loop.
What kind of change does this PR introduce?
Just a proposal, I have no good idea of the good fix. I would like an automatic way, that could analysed generator voltage controls or transformer voltage controls, or both. But we need also a parameter.
We must include in this PR all the good idea of #1032 : parameter, VSC management, etc.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: