Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PV -> PQ switch counter #687

Merged
merged 1 commit into from Jan 3, 2023
Merged

Refactor PV -> PQ switch counter #687

merged 1 commit into from Jan 3, 2023

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jan 2, 2023

Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring

What is the current behavior? (You can also link to an open issue here)
switch PV -> PQ counter of reactive limit outer loop is driven by LfBus.setVoltageControlEnabled calls. This is quite dangerous because there is many other reason that could lead to switch of voltage control that PV -> PQ switch (like validation checks).

What is the new behavior (if this is a feature change)?
PV -> PQ counter is now managed directly in reactive limits outer loop context.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg geofjamg requested a review from annetill January 2, 2023 09:52
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.3% 85.3% Coverage
0.0% 0.0% Duplication

@geofjamg
Copy link
Member Author

geofjamg commented Jan 3, 2023

Low coverage is because of the 3 traces, that cannot be covered as logback config is at debug.

@annetill annetill merged commit a51e47d into main Jan 3, 2023
@annetill annetill deleted the refactor_pv_pq_counter branch January 3, 2023 15:29
geofjamg added a commit that referenced this pull request Jan 5, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
caioluke pushed a commit that referenced this pull request Jan 10, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants