Use IIDM OverLoadManagementSystem #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
annetill
changed the title
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
approved these changes
Jan 19, 2024
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
…ybl/powsybl-open-loadflow into automation_systems_iidm1.12
- three winding transformer support; - Side management; - Update parameter. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Remove useless update conditions. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
geofjamg
reviewed
May 14, 2024
| branchToMonitor.getId(), i * ib, threshold * ib, branchToOperate.getId()); | ||
| branchesToOpen.add(branchToOperate); | ||
| break; | ||
| } else if (!branchTripping.branchOpen() && branchToOperate.isConnectedAtBothSides()) { |
There was a problem hiding this comment.
Should it be?:
} else if (!branchTripping.branchOpen() && !branchToOperate.isConnectedAtBothSides()) {There was a problem hiding this comment.
In previous code it was:
} else if (!system.isSwitchOpen() && !switchToOperate.isConnectedAtBothSides()) {
geofjamg
approved these changes
May 14, 2024
annetill
reviewed
May 14, 2024
src/main/java/com/powsybl/openloadflow/ac/outerloop/AutomationSystemOuterLoop.java
Show resolved
Hide resolved
annetill
reviewed
May 14, 2024
| // we have an issue with connectivity here: we have to start temporary changes and undo them just after to | ||
| // be able to retrieve the enabled and disabled elements compared to state just after restoring the initial topology | ||
| // (restoreInitialTopology method). | ||
| network.getConnectivity().startTemporaryChanges(); |
There was a problem hiding this comment.
Mmmm finally what is the next step @flo-dup about this strange code?
annetill
reviewed
May 14, 2024
| if (parameters.isSimulateAutomationSystems()) { | ||
| boolean connectedSide1Before = branch.getTerminal1().isConnected(); | ||
| boolean connectedSide2Before = branch.getTerminal2().isConnected(); | ||
| boolean connectedSide1After = !isDisabled() && isConnectedSide1(); |
There was a problem hiding this comment.
Here add a comment maybe because isConnectedSide1() and isConnectedSide2() is not needed for the moment?
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
annetill
approved these changes
May 14, 2024
There was a problem hiding this comment.
Thanks @jeandemanged ! Three-windings transformer missing, to be done in another PR.
|
|
geofjamg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
OLF has its own iIDM extension to describe automation systems
What is the new behavior (if this is a feature change)?
Remove OLF iIDM extension, use powsybl-core new automation systems available in iIDM v1.12 (see powsybl/powsybl-core#2779)
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: