Add isSecure for RaoResult #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
pet-mit
requested changes
Jan 17, 2024
...sult/rao-result-impl/src/main/java/com/powsybl/openrao/data/raoresultimpl/RaoResultImpl.java
Outdated
Show resolved
Hide resolved
...-exporter/swe-cne-exporter/src/main/java/com/powsybl/openrao/data/swecneexporter/SweCne.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
pet-mit
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Please update the documentation here: https://github.com/farao-community/farao-community.github.io/blob/master/pages/docs/output-data/rao-result/rao-result-json.md
i realize this is more complicated than it seemed. we may want to do some refactoring in the future. it would be nice to have a review from @phiedw too
...rao-result/rao-result-api/src/main/java/com/powsybl/openrao/data/raoresultapi/RaoResult.java
Outdated
Show resolved
Hide resolved
...rao-result/rao-result-api/src/main/java/com/powsybl/openrao/data/raoresultapi/RaoResult.java
Outdated
Show resolved
Hide resolved
...rao-result/rao-result-api/src/main/java/com/powsybl/openrao/data/raoresultapi/RaoResult.java
Outdated
Show resolved
Hide resolved
...sult/rao-result-impl/src/main/java/com/powsybl/openrao/data/raoresultimpl/RaoResultImpl.java
Outdated
Show resolved
Hide resolved
...sult/rao-result-impl/src/main/java/com/powsybl/openrao/data/raoresultimpl/RaoResultImpl.java
Outdated
Show resolved
Hide resolved
...sult/rao-result-impl/src/main/java/com/powsybl/openrao/data/raoresultimpl/RaoResultImpl.java
Outdated
Show resolved
Hide resolved
| return false; | ||
| } | ||
| if (Arrays.stream(u).toList().contains(PhysicalParameter.FLOW)) { | ||
| return optimizedFlowCnecs.stream() |
There was a problem hiding this comment.
use functional cost here also
.../java/com/powsybl/openrao/searchtreerao/result/impl/PreventiveAndCurativesRaoResultImpl.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public boolean isSecure(Instant optimizedInstant, PhysicalParameter... u) { | ||
| if (ComputationStatus.FAILURE.equals(getComputationStatus())) { |
There was a problem hiding this comment.
also check computation status map
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
pet-mit
approved these changes
Jan 22, 2024
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
Add isSecure(...) methods in RaoResult Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
New feature
What is the new behavior (if this is a feature change)?
RaoResult objects now provides 3 new methods that allow client to assess the RAO result security status (i.e. positive margin on all Cnecs) , for multiple instants of optimization, and separately for each of the Cnec kind (Flow, Voltage and Angle).
These methods are :
This PR also add a method getLastInstant() to the CRAC API that allow to get the last instant based on order (biggest order one). This instant should correspond to the final optimisation instant.
Does this PR introduce a breaking change or deprecate an API?