fixed global virtual costs and a .equals not being used #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
pet-mit
approved these changes
Mar 21, 2024
jipea
pushed a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: jipea <arnould.jp@gmail.com>
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In the merged results, the virtual cost was not always checking virtual costs caused by preventive perimeter cnecs.
In AutomatonPerimeterResultImpl, we checked equality on states using != instead of .equals.
What is the new behavior (if this is a feature change)?
In the merged results, the virtual cost also checks preventive perimeter cnecs.
In AutomatonPerimeterResultImpl, we now check equality with.equals.
Does this PR introduce a breaking change or deprecate an API?