Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #923

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Refactor tests #923

merged 16 commits into from
Mar 21, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Mar 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • CSA CRAC import tests were refactored to use less files and and common network (faster)
  • CurrentLimit and VoltageLimit queries were updated to match the latest CGMES version
  • Import details for not imported CNECs, contingencies or remedial actions were made more homogeneous

@bqth29
Add graph dependency for network elementary actions queries
dcb5fb3 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
inBaseCase + TATL = only one CNEC
2485681 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Refactor contingencies import messages
c912870 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Angle and Voltage CNECs + remove TC1&TC2
c3bf035 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
PstRangeActions tests
f8ed532 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Injection setpoint actions tests
a2d58b0 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Remedial actions tests
8f55fc8 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Remove useless files
b4922a0 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Remedial action groups tests
c0b9544 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Fix tests
6c67894 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
rename operational limits query fields
d486c04 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
VoltageCNECs tests with Equipments and Terminals
47bfab6 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Revert query for CurrentLimits
4647ab0 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Codestyle
bfa48e9 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Only use Equipment in VoltageCnec query
d132bc2 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29
Remove useless methods in utils
00530fa 
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
benrejebmoh
benrejebmoh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@benrejebmoh benrejebmoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that you have a different indents configuration from the rest of the team, which can make it harder for review

@jipea jipea merged commit 7b18f2f into main Mar 21, 2024
6 checks passed
@pet-mit pet-mit deleted the fix/csa_operational_limits branch April 4, 2024 15:20
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
@bqth29 @MartinBelthle
Refactor tests (#923)
ce7a42a 
* Add graph dependency for network elementary actions queries

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* inBaseCase + TATL = only one CNEC

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Refactor contingencies import messages

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Angle and Voltage CNECs + remove TC1&TC2

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* PstRangeActions tests

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Injection setpoint actions tests

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Remedial actions tests

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Remove useless files

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Remedial action groups tests

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Fix tests

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* rename operational limits query fields

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* VoltageCNECs tests with Equipments and Terminals

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Revert query for CurrentLimits

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Codestyle

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Only use Equipment in VoltageCnec query

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Remove useless methods in utils

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

---------

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrejebmoh benrejebmoh benrejebmoh approved these changes

@jipea jipea jipea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bqth29 @benrejebmoh @jipea