Import mnecs #925
Merged
Import mnecs #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
bqth29
reviewed
Mar 21, 2024
Comment on lines
128
to
129
| return aeSecuredForRegion.map(rawRegionId -> rawRegionId.substring(rawRegionId.lastIndexOf("/") + 1).equals(regionEic)).orElse(false); | ||
| } |
There was a problem hiding this comment.
Instead of lastIndexOf("/") I think it could be interesting to use the structure of an EIC code which is 16-character long and only accepts uppercase letters, digits, +, - and _. Maybe you could you get the EIC code with a regex like:
http://energy.referencedata.eu/energy/EIC/((?:[A-Z]|[0-9]|_|-|\+){16})
Comment on lines
133
to
134
| return aeScannedForRegion.map(rawRegionId -> rawRegionId.substring(rawRegionId.lastIndexOf("/") + 1).equals(regionEic)).orElse(false); | ||
| } |
...java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/MnecTest.java
Outdated
Show resolved
Hide resolved
...raccreation/creator/csaprofile/craccreator/parameters/JsonCsaCracCreationParametersTest.java
Outdated
Show resolved
Hide resolved
...raccreation/creator/csaprofile/craccreator/parameters/JsonCsaCracCreationParametersTest.java
Outdated
Show resolved
Hide resolved
...java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/MnecTest.java
Outdated
Show resolved
Hide resolved
...java/com/powsybl/openrao/data/craccreation/creator/csaprofile/craccreator/cnec/MnecTest.java
Show resolved
Hide resolved
...l/openrao/data/craccreation/creator/csaprofile/parameters/JsonCsaCracCreationParameters.java
Show resolved
Hide resolved
...wsybl/openrao/data/craccreation/creator/csaprofile/parameters/CsaCracCreationParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
bqth29
approved these changes
Mar 21, 2024
jipea
pushed a commit
that referenced
this pull request
Apr 2, 2024
* add csa crac creation parameters Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * mnec test Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * adapt unit test to new test structure after merge with master Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * fix after review Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> --------- Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> Signed-off-by: jipea <arnould.jp@gmail.com>
MartinBelthle
pushed a commit
that referenced
this pull request
May 28, 2024
* add csa crac creation parameters Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * mnec test Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * adapt unit test to new test structure after merge with master Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> * fix after review Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> --------- Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com> Signed-off-by: belthlemar <martin.belthle@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: