Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to new shunt API #125

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Update documentation to new shunt API #125

merged 2 commits into from
Mar 25, 2020

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 24, 2020

Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Doc update for new shunt API in PR powsybl/powsybl-core#1202

Other information:

Must only be merged when PR on powsybl-core is merged

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Copy link

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MioRtia, it looks much clearer to me now.

Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, but the documentation is very clear and helpful. Thanks Miora !

docs/iidm/model/shuntCompensator.md Show resolved Hide resolved
…apacitor or a reactor

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd merged commit c584079 into master Mar 25, 2020
@miovd miovd deleted the doc_new_shunt branch March 25, 2020 09:08
miovd added a commit that referenced this pull request Apr 20, 2020
miovd added a commit that referenced this pull request Apr 20, 2020
This reverts commit c584079.

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd added a commit that referenced this pull request Apr 23, 2020
This reverts commit c584079.

Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants