Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shortcircuit analysis api #640

Merged
merged 6 commits into from Sep 13, 2023
Merged

add shortcircuit analysis api #640

merged 6 commits into from Sep 13, 2023

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

#433

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@CBiasuzzi
adds short-circuit analysis APIs
f77edbc 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi
fixes error in doctest
6c2bd4f 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi CBiasuzzi changed the title Shortcircuit analysis [WIP] Shortcircuit analysis Aug 23, 2023
EtienneLt
EtienneLt requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small details

java/src/main/java/com/powsybl/dataframe/shortcircuit/adders/BusFaultDataframeAdder.java Show resolved Hide resolved
cpp/src/bindings.cpp Outdated Show resolved Hide resolved
java/src/main/java/com/powsybl/python/shortcircuit/LimitViolationFaultContext.java Show resolved Hide resolved
pypowsybl/shortcircuit.py Show resolved Hide resolved
java/src/test/java/com/powsybl/python/shortcircuit/ShortCircuitAnalysisTest.java Show resolved Hide resolved
pypowsybl/shortcircuit.py Outdated Show resolved Hide resolved
pypowsybl/shortcircuit.py Outdated Show resolved Hide resolved
java/src/main/java/com/powsybl/dataframe/shortcircuit/adders/ShortCircuitContextFaultAdder.java Show resolved Hide resolved
java/src/main/java/com/powsybl/dataframe/shortcircuit/adders/ShortCircuitFaultAdderFactory.java Show resolved Hide resolved
cpp/src/pypowsybl-api.h Show resolved Hide resolved
colinepiloquet
colinepiloquet reviewed Aug 23, 2023
View reviewed changes
cpp/src/pypowsybl.h Outdated Show resolved Hide resolved
colinepiloquet
colinepiloquet requested changes Aug 23, 2023
View reviewed changes
docs/reference/shortcircuit.rst Outdated Show resolved Hide resolved
pypowsybl/shortcircuit.py Show resolved Hide resolved
java/src/main/java/com/powsybl/dataframe/shortcircuit/adders/BusFaultDataframeAdder.java Outdated Show resolved Hide resolved
pypowsybl/shortcircuit.py Outdated Show resolved Hide resolved
cpp/src/pypowsybl.cpp Outdated Show resolved Hide resolved
docs/user_guide/shortcircuit.rst Show resolved Hide resolved
@CBiasuzzi
adds missing SPDX id, fixes docs, typos and indentations
c2cc231 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi
makes r and x, in a fault, optional
fec2bb4 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi
fixes case format in SC results dataframe columns names
f5ff5b7 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi
Merge branch 'main' into shortcircuit_analysis
09c5f4c
@EtienneLt EtienneLt changed the title [WIP] Shortcircuit analysis Shortcircuit analysis Sep 13, 2023
@EtienneLt EtienneLt changed the title Shortcircuit analysis add shortcircuit analysis api Sep 13, 2023
@EtienneLt EtienneLt merged commit bf7b7a3 into main Sep 13, 2023
7 checks passed
@EtienneLt EtienneLt deleted the shortcircuit_analysis branch September 13, 2023 08:18
@EtienneLt EtienneLt mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneLt EtienneLt EtienneLt approved these changes

@colinepiloquet colinepiloquet colinepiloquet approved these changes

Assignees

@CBiasuzzi CBiasuzzi

Labels
status: ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CBiasuzzi @EtienneLt @colinepiloquet