Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor network area diagram parameters #675

Merged
merged 3 commits into from Nov 22, 2023
Merged

Conversation

EtienneLt
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@EtienneLt EtienneLt self-assigned this Nov 17, 2023
@EtienneLt EtienneLt force-pushed the refactor-nad-parameters branch 2 times, most recently from 38754e8 to 73039af Compare November 17, 2023 15:45
Copy link
Contributor

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring the NadParameters. It will make it symmetrical to the SldParameters!

pypowsybl/network/impl/network.py Show resolved Hide resolved
tests/test_network.py Outdated Show resolved Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Copy link
Contributor

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a little typo remaining and then it's good for me!

pypowsybl/network/impl/network.py Outdated Show resolved Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt merged commit ebf2708 into main Nov 22, 2023
7 checks passed
@EtienneLt EtienneLt deleted the refactor-nad-parameters branch November 22, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants