Remove voltage level filter from pypowsybl #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues for bounds Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
EtienneLt
force-pushed
the
move-filter
branch
from
3b1aaba
to
3d7bc0e
Compare
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
EtienneLt
force-pushed
the
move-filter
branch
from
3d7bc0e
to
388eee0
Compare
So-Fras
changed the title
EtienneLt
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No but it is the twin of powsybl/powsybl-diagram#566
What kind of change does this PR introduce?
It removes a voltage level filter from pypowsybl network-area-diagram related code. This filter is now integrated in the powsybl-diagram code.
It also adapts values received from pypowsybl users (who set -1 values for the bounds they do not use) to fit the Java code.
Does this PR introduce a breaking change or deprecate an API?
No