Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack support #27

Closed
ppadovani opened this issue Jan 17, 2018 · 13 comments
Closed

x-pack support #27

ppadovani opened this issue Jan 17, 2018 · 13 comments

Comments

@ppadovani
Copy link
Owner

ppadovani commented Jan 17, 2018

From the comment left on the Kibana issue:

Thanks for your work and 6.0.1 release!

based on kibana 6.0.1, after installed this plugin, some kibana features doesnt work well.

when click timelion, it shows an error message:

-- shows an image with an error when attempting to use timelion. --

if x-pack installed, some x-pack feature "discover" has another error message in "Foreach"

@sccds

@ppadovani
Copy link
Owner Author

ppadovani commented Jan 17, 2018

I have a fix for the error message... but I need stack traces from the javascript console to fix the others. I don't have x-pack installed....I'll install it after I get timelion working again. Totally my bad, I should have retested timelion prior to release.

My hack to intercept the discovery app and inject a new template based on route is causing timelion to not startup.... I'll need to understand what in timelion is conflicting with what I did.

ppadovani added a commit that referenced this issue Jan 17, 2018
ppadovani added a commit that referenced this issue Jan 17, 2018
@ppadovani
Copy link
Owner Author

I believe this is fixed, cutting and releasing.

@sccds
Copy link

sccds commented Jan 17, 2018

Thank you very much!

When I using the plugin 6.0.1-1.0.1 and x-pack, the "discover" shows "ForEach" error.

image

For other tags of x-pack, no error. "timelion" fixed.

@ppadovani ppadovani reopened this Jan 17, 2018
@ppadovani
Copy link
Owner Author

I'll take a look... I thought I had fixed this...

@ppadovani
Copy link
Owner Author

ppadovani commented Jan 17, 2018

I am unable to reproduce an error on the discover application with x-pack installed. Could this be related to a specific index mapping? Can you toggle the nested flag on the index in the management setup for this plugin?

I did notice that I'm getting a permission error accessing the kibana index... which I'll look into.

@sccds
Copy link

sccds commented Jan 17, 2018

thank you!
I have two kinds of data, one is nested, the other is not nested. I did select nested flag in the setup for the nested data. mapping like this:

PUT some_index_name
{
  "settings": {
    "index": {
      "number_of_shards": 5,
      "number_of_replicas": 1
    }
  },
  "mappings": {
    "xxx": {
      "properties": {
        "key1": {
          "type": "keyword"
        },
        "key2": {
          "type": "keyword"
        },
        "key3": {
          "type": "keyword"
        },
        "key4_nest": {
          "type": "nested",
          "properties": {
            "timestamp": {
              "type": "date",
              "format": "epoch_millis",
              "store": true
            },
            "some_text": {
              "type": "text",
              "store": true,
              "fields": {
                "cn": {
                  "type": "text",
                  "store": true,
                  "analyzer": "ik_max_word"
                },
                "en": {
                  "type": "text",
                  "store": true,
                  "analyzer": "english"
                }
              }
            }
          }
        }
      }
    }
  }
}
PUT the_other_index
{
  "settings": {
    "index": {
      "number_of_shards": 5,
      "number_of_replicas": 1
    }
  },
  "mappings": {
    "xxx": {
      "properties": {
        "key1": {
          "type": "keyword"
        },
        "key2": {
          "type": "keyword"
        },
        "key3": {
          "type": "keyword"
        },
        "timestamp": {
          "type": "date"
        }
      }
    }
  }
}

I have to wait until tomorrow( I am in Asia timezone ) to provide more details.

@ppadovani ppadovani changed the title 6.0.1 plugin breaks timelion 6.0.1 plugin breaks timelion/x-pack Jan 17, 2018
@ppadovani
Copy link
Owner Author

For the security issue, looks like the default roles do not give the Kibana user access to:
indices:admin/mappings/get

This is needed by my plugin in order to load the nested field information. I'm playing with roles and privs to see if I can figure out how to get this working.

@yuyiyu2017
Copy link

@ppadovani Thanks for your plugin,it is very useful.but when I install the x-pack,the version of 5.6.5 also has this problem.

@ppadovani ppadovani changed the title 6.0.1 plugin breaks timelion/x-pack x-pack support Jan 18, 2018
@ppadovani
Copy link
Owner Author

I changed the title of this issue to simply x-pack support. I've got some code that fixes a few things, but there are still some issues I'm working on. I'll get the support in place for the 6.0.1 plugin, then back port and test through all supported versions of my plugin.

I would expect to have this fixed and released this weekend.

@ppadovani
Copy link
Owner Author

Ok, I think I have x-pack support working in 6.0.1. I made a mistake in how I configured the route for fetching index mappings. This support will require additional manual configuration of a role against a user in X-pack. I will document the setup steps in the README.md as part of the release. I want to continue some testing prior to release, so I'm still targeting this weekend to release the updated plugin.

Back-porting to the other releases should be pretty trivial, and I think I will be able to release all other version updates this weekend.

ppadovani pushed a commit that referenced this issue Jan 18, 2018
@ppadovani
Copy link
Owner Author

Had some time at lunch, released 6.0.1-1.0.2 w/ x-pack support. Please let me know if there are still issues with that version.

ppadovani added a commit that referenced this issue Jan 20, 2018
ppadovani added a commit that referenced this issue Jan 20, 2018
ppadovani added a commit that referenced this issue Jan 20, 2018
@ppadovani
Copy link
Owner Author

All releases updated to support x-pack.

@sccds
Copy link

sccds commented Jan 21, 2018

I tried it, it is a great plugin!
Currently no new problem found.
Thank you very much!

ppadovani added a commit that referenced this issue Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants