Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tika support #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ppalaga
Copy link
Owner

@ppalaga ppalaga commented Mar 27, 2020

No description provided.

Copy link
Owner Author

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiriOndrusek some comments inline. More later.

Comment on lines 51 to 54
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-tika</artifactId>
</dependency>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-tika</artifactId>
</dependency>

@JiriOndrusek quarkus-tika-deployment pulls quarkus-tika transitively.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppalaga
If I remove dependency, I get error during build:

[ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute (sanity-checks) on project camel-quarkus-tika-deployment: Execution sanity-checks of goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute failed:
[ERROR] Violations in the parity between deployment module dependencies and runtime module dependencies:
[ERROR]
[ERROR] extensions/tika/deployment/pom.xml must depend on camel-quarkus-tika

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, sorry, navrhol som to vyhodiť, lebo som si myslel, že to je io.quarkus:quarkus-tika. ale io.quarkus:quarkus-tika to zjavne nie je :)

extensions/tika/deployment/pom.xml Show resolved Hide resolved
integration-tests/tika/pom.xml Outdated Show resolved Hide resolved
@JiriOndrusek
Copy link

@ppalaga I've created draft PR on my fork: apache#998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants